iommu: Fix static checker warning in iommu_insert_device_resv_regions

eauger · joergroedel · commit a514a6e241f0 · 2017-02-06T14:08:53.000+01:00
In case the device reserved region list is void, the returned value of iommu_insert_device_resv_regions is uninitialized. Let's return 0 in that case. This fixes commit 6c65fb3 ("iommu: iommu_get_group_resv_regions"). Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Eric Auger <eric.auger@redhat.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
@@ -205,7 +205,7 @@ iommu_insert_device_resv_regions(struct list_head *dev_resv_regions,
 				 struct list_head *group_resv_regions)
 {
 	struct iommu_resv_region *entry;
-	int ret;
+	int ret = 0;
 
 	list_for_each_entry(entry, dev_resv_regions, list) {
 		ret = iommu_insert_resv_region(entry, group_resv_regions);

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ iommu_insert_device_resv_regions(struct list_head *dev_resv_regions,`
`205`	`205`	`struct list_head *group_resv_regions)`
`206`	`206`	`{`
`207`	`207`	`struct iommu_resv_region *entry;`
`208`		`- int ret;`
	`208`	`+ int ret = 0;`
`209`	`209`
`210`	`210`	`list_for_each_entry(entry, dev_resv_regions, list) {`
`211`	`211`	`ret = iommu_insert_resv_region(entry, group_resv_regions);`