mm: reorder can_do_mlock to fix audit denial

jeffvanderstoep · torvalds · commit a5a6579db33a · 2015-03-12T18:46:08.000-07:00
A userspace call to mmap(MAP_LOCKED) may result in the successful locking
of memory while also producing a confusing audit log denial.  can_do_mlock
checks capable and rlimit.  If either of these return positive
can_do_mlock returns true.  The capable check leads to an LSM hook used by
apparmour and selinux which produce the audit denial.  Reordering so
rlimit is checked first eliminates the denial on success, only recording a
denial when the lock is unsuccessful as a result of the denial.

Signed-off-by: Jeff Vander Stoep &lt;jeffv@google.com&gt;
Acked-by: Nick Kralevich &lt;nnk@google.com&gt;
Cc: Jeff Vander Stoep &lt;jeffv@google.com&gt;
Cc: Sasha Levin &lt;sasha.levin@oracle.com&gt;
Cc: "Paul E. McKenney" &lt;paulmck@linux.vnet.ibm.com&gt;
Cc: Rik van Riel &lt;riel@redhat.com&gt;
Cc: Vlastimil Babka &lt;vbabka@suse.cz&gt;
Cc: Paul Cassella &lt;cassella@cray.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/mm/mlock.c b/mm/mlock.c
@@ -26,10 +26,10 @@
 
 int can_do_mlock(void)
 {
-	if (capable(CAP_IPC_LOCK))
-		return 1;
 	if (rlimit(RLIMIT_MEMLOCK) != 0)
 		return 1;
+	if (capable(CAP_IPC_LOCK))
+		return 1;
 	return 0;
 }
 EXPORT_SYMBOL(can_do_mlock);

Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,10 @@`
`26`	`26`
`27`	`27`	`int can_do_mlock(void)`
`28`	`28`	`{`
`29`		`- if (capable(CAP_IPC_LOCK))`
`30`		`- return 1;`
`31`	`29`	`if (rlimit(RLIMIT_MEMLOCK) != 0)`
`32`	`30`	`return 1;`
	`31`	`+ if (capable(CAP_IPC_LOCK))`
	`32`	`+ return 1;`
`33`	`33`	`return 0;`
`34`	`34`	`}`
`35`	`35`	`EXPORT_SYMBOL(can_do_mlock);`