qlogicpti: Return correct error code

musicakc · martinkpetersen · commit a6d24143fca4 · 2016-03-01T20:06:49.000-05:00
The return value of of_ioremap on failure should be -ENODEV and not
-1.

Found using Coccinelle. A simplified version of the semantic patch
used is:

//&lt;smpl&gt;
@@
expression *e;
@@

e = of_ioremap(...);
if (e == NULL) {
...
return
- -1
+ -ENODEV
;
}
//&lt;/smpl&gt;

The single call site only checks that the return value is less than 0,
hence no change is required at the call site.

Signed-off-by: Amitoj Kaur Chawla &lt;amitoj1606@gmail.com&gt;
Reviewed-by: Shane Seymour &lt;shane.seymour@hpe.com&gt;
Reviewed-by: Hannes Reinicke &lt;hare@suse.de&gt;
Signed-off-by: Martin K. Petersen &lt;martin.petersen@oracle.com&gt;
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
@@ -710,15 +710,15 @@ static int qpti_map_regs(struct qlogicpti *qpti)
 				 "PTI Qlogic/ISP");
 	if (!qpti->qregs) {
 		printk("PTI: Qlogic/ISP registers are unmappable\n");
-		return -1;
+		return -ENODEV;
 	}
 	if (qpti->is_pti) {
 		qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096),
 					sizeof(unsigned char),
 					"PTI Qlogic/ISP statreg");
 		if (!qpti->sreg) {
 			printk("PTI: Qlogic/ISP status register is unmappable\n");
-			return -1;
+			return -ENODEV;
 		}
 	}
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -710,15 +710,15 @@ static int qpti_map_regs(struct qlogicpti *qpti)`
`710`	`710`	`"PTI Qlogic/ISP");`
`711`	`711`	`if (!qpti->qregs) {`
`712`	`712`	`printk("PTI: Qlogic/ISP registers are unmappable\n");`
`713`		`- return -1;`
	`713`	`+ return -ENODEV;`
`714`	`714`	`}`
`715`	`715`	`if (qpti->is_pti) {`
`716`	`716`	`qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096),`
`717`	`717`	`sizeof(unsigned char),`
`718`	`718`	`"PTI Qlogic/ISP statreg");`
`719`	`719`	`if (!qpti->sreg) {`
`720`	`720`	`printk("PTI: Qlogic/ISP status register is unmappable\n");`
`721`		`- return -1;`
	`721`	`+ return -ENODEV;`
`722`	`722`	`}`
`723`	`723`	`}`
`724`	`724`	`return 0;`