x86/intel/quark: Run IMR self-test on IMR capble hw only

0xB0D · Ingo Molnar · commit a6fcb6d4804b · 2015-04-02T12:47:50.000+02:00
Automated testing with LKP shows IMR self test code running and printing error messages on QEMU hardware lacking IMR support. Update IMR self-test code to run only when IMR hardware should be present. Tested on Quark X1000 and QEMU. Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie> Acked-by: Ong Boon Leong <boon.leong.ong@intel.com> Cc: Borislav Petkov <bp@alien8.de> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: andriy.shevchenko@intel.com Cc: dvhart@linux.intel.com Cc: huang.ying.caritas@gmail.com Cc: ying.huang@intel.com Link: http://lkml.kernel.org/r/1427800536-32339-1-git-send-email-pure.logic@nexus-software.ie Signed-off-by: Ingo Molnar <mingo@kernel.org>
diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c
@@ -11,6 +11,7 @@
  */
 
 #include <asm-generic/sections.h>
+#include <asm/cpu_device_id.h>
 #include <asm/imr.h>
 #include <linux/init.h>
 #include <linux/mm.h>
@@ -101,14 +102,21 @@ static void __init imr_self_test(void)
 	}
 }
 
+static const struct x86_cpu_id imr_ids[] __initconst = {
+	{ X86_VENDOR_INTEL, 5, 9 },	/* Intel Quark SoC X1000. */
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, imr_ids);
+
 /**
  * imr_self_test_init - entry point for IMR driver.
  *
  * return: -ENODEV for no IMR support 0 if good to go.
  */
 static int __init imr_self_test_init(void)
 {
-	imr_self_test();
+	if (x86_match_cpu(imr_ids))
+		imr_self_test();
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`*/`
`12`	`12`
`13`	`13`	`#include <asm-generic/sections.h>`
	`14`	`+#include <asm/cpu_device_id.h>`
`14`	`15`	`#include <asm/imr.h>`
`15`	`16`	`#include <linux/init.h>`
`16`	`17`	`#include <linux/mm.h>`
`@@ -101,14 +102,21 @@ static void __init imr_self_test(void)`
`101`	`102`	`}`
`102`	`103`	`}`
`103`	`104`
	`105`	`+static const struct x86_cpu_id imr_ids[] __initconst = {`
	`106`	`+ { X86_VENDOR_INTEL, 5, 9 }, /* Intel Quark SoC X1000. */`
	`107`	`+ {}`
	`108`	`+};`
	`109`	`+MODULE_DEVICE_TABLE(x86cpu, imr_ids);`
	`110`	`+`
`104`	`111`	`/**`
`105`	`112`	`* imr_self_test_init - entry point for IMR driver.`
`106`	`113`	`*`
`107`	`114`	`* return: -ENODEV for no IMR support 0 if good to go.`
`108`	`115`	`*/`
`109`	`116`	`static int __init imr_self_test_init(void)`
`110`	`117`	`{`
`111`		`- imr_self_test();`
	`118`	`+ if (x86_match_cpu(imr_ids))`
	`119`	`+ imr_self_test();`
`112`	`120`	`return 0;`
`113`	`121`	`}`
`114`	`122`