Skip to content

Commit a777c89

Browse files
Manish chopradavem330
authored andcommitted
netxen_nic: restrict force firmware dump when dump is disabled.
o Set the ethtool_dump flag (=ETH_FW_DUMP_DISABLE) when dump is disabled. o update driver version to 4.0.80 Signed-off-by: Manish chopra <manish.chopra@qlogic.com> Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d0087b2 commit a777c89

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

drivers/net/ethernet/qlogic/netxen/netxen_nic.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@
5353

5454
#define _NETXEN_NIC_LINUX_MAJOR 4
5555
#define _NETXEN_NIC_LINUX_MINOR 0
56-
#define _NETXEN_NIC_LINUX_SUBVERSION 79
57-
#define NETXEN_NIC_LINUX_VERSIONID "4.0.79"
56+
#define _NETXEN_NIC_LINUX_SUBVERSION 80
57+
#define NETXEN_NIC_LINUX_VERSIONID "4.0.80"
5858

5959
#define NETXEN_VERSION_CODE(a, b, c) (((a) << 24) + ((b) << 16) + (c))
6060
#define _major(v) (((v) >> 24) & 0xff)

drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,12 @@ netxen_get_dump_flag(struct net_device *netdev, struct ethtool_dump *dump)
826826
dump->len = mdump->md_dump_size;
827827
else
828828
dump->len = 0;
829-
dump->flag = mdump->md_capture_mask;
829+
830+
if (!mdump->md_enabled)
831+
dump->flag = ETH_FW_DUMP_DISABLE;
832+
else
833+
dump->flag = mdump->md_capture_mask;
834+
830835
dump->version = adapter->fw_version;
831836
return 0;
832837
}
@@ -840,8 +845,10 @@ netxen_set_dump(struct net_device *netdev, struct ethtool_dump *val)
840845

841846
switch (val->flag) {
842847
case NX_FORCE_FW_DUMP_KEY:
843-
if (!mdump->md_enabled)
844-
mdump->md_enabled = 1;
848+
if (!mdump->md_enabled) {
849+
netdev_info(netdev, "FW dump not enabled\n");
850+
return 0;
851+
}
845852
if (adapter->fw_mdump_rdy) {
846853
netdev_info(netdev, "Previous dump not cleared, not forcing dump\n");
847854
return 0;

0 commit comments

Comments
 (0)