aquantia: Fix transient invalid link down/up indications

cail · davem330 · commit a7bb1bea3a29 · 2017-09-26T13:44:31.000-07:00
Due to a bug in aquantia atlantic card firmware, it sometimes reports
invalid link speed bits. That caused driver to report link down events,
although link itself is totally fine.

This patch ignores such out of blue readings.

Signed-off-by: Pavel Belous &lt;Pavel.Belous@aquantia.com&gt;
Signed-off-by: Igor Russkikh &lt;igor.russkikh@aquantia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
@@ -351,8 +351,7 @@ int hw_atl_utils_mpi_get_link_status(struct aq_hw_s *self)
 			break;
 
 		default:
-			link_status->mbps = 0U;
-			break;
+			return -EBUSY;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -351,8 +351,7 @@ int hw_atl_utils_mpi_get_link_status(struct aq_hw_s *self)`
`351`	`351`	`break;`
`352`	`352`
`353`	`353`	`default:`
`354`		`- link_status->mbps = 0U;`
`355`		`- break;`
	`354`	`+ return -EBUSY;`
`356`	`355`	`}`
`357`	`356`	`}`
`358`	`357`