Avoid using variable-length arrays in kernel/sys.c

torvalds · torvalds · commit a84a79e4d369 · 2011-10-17T08:24:24.000-07:00
The size is always valid, but variable-length arrays generate worse code
for no good reason (unless the function happens to be inlined and the
compiler sees the length for the simple constant it is).

Also, there seems to be some code generation problem on POWER, where
Henrik Bakken reports that register r28 can get corrupted under some
subtle circumstances (interrupt happening at the wrong time?).  That all
indicates some seriously broken compiler issues, but since variable
length arrays are bad regardless, there's little point in trying to
chase it down.

"Just don't do that, then".

Reported-by: Henrik Grindal Bakken &lt;henribak@cisco.com&gt;
Cc: Benjamin Herrenschmidt &lt;benh@kernel.crashing.org&gt;
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/kernel/sys.c b/kernel/sys.c
@@ -1172,7 +1172,7 @@ DECLARE_RWSEM(uts_sem);
 static int override_release(char __user *release, int len)
 {
 	int ret = 0;
-	char buf[len];
+	char buf[65];
 
 	if (current->personality & UNAME26) {
 		char *rest = UTS_RELEASE;

Original file line number	Diff line number	Diff line change
`@@ -1172,7 +1172,7 @@ DECLARE_RWSEM(uts_sem);`
`1172`	`1172`	`static int override_release(char __user *release, int len)`
`1173`	`1173`	`{`
`1174`	`1174`	`int ret = 0;`
`1175`		`- char buf[len];`
	`1175`	`+ char buf[65];`
`1176`	`1176`
`1177`	`1177`	`if (current->personality & UNAME26) {`
`1178`	`1178`	`char *rest = UTS_RELEASE;`