Skip to content

Commit a8c3954

Browse files
author
Al Viro
committed
osf_wait4(): fix infoleak
failing sys_wait4() won't fill struct rusage... Cc: stable@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent a7cc722 commit a8c3954

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

arch/alpha/kernel/osf_sys.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1201,8 +1201,10 @@ SYSCALL_DEFINE4(osf_wait4, pid_t, pid, int __user *, ustatus, int, options,
12011201
if (!access_ok(VERIFY_WRITE, ur, sizeof(*ur)))
12021202
return -EFAULT;
12031203

1204-
err = 0;
1205-
err |= put_user(status, ustatus);
1204+
err = put_user(status, ustatus);
1205+
if (ret < 0)
1206+
return err ? err : ret;
1207+
12061208
err |= __put_user(r.ru_utime.tv_sec, &ur->ru_utime.tv_sec);
12071209
err |= __put_user(r.ru_utime.tv_usec, &ur->ru_utime.tv_usec);
12081210
err |= __put_user(r.ru_stime.tv_sec, &ur->ru_stime.tv_sec);

0 commit comments

Comments
 (0)