Skip to content

Commit aa3bee0

Browse files
committed
lustre: delete linux/lustre_debug.h
There was only one macro in here, LL_CDEBUG_PAGE(). So open code it in the 2 places it was used so that the developer seeing it can see just how horrid it really is, and they can remove it as I doubt it really is ever needed anymore. But for now, keep the same functionality and remove a whole file (with a duplicate name of other files in the lustre repo, another confusion...) Cc: Peng Tao <bergwolf@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 187df69 commit aa3bee0

File tree

4 files changed

+11
-53
lines changed

4 files changed

+11
-53
lines changed

drivers/staging/lustre/lustre/include/linux/lustre_debug.h

Lines changed: 0 additions & 47 deletions
This file was deleted.

drivers/staging/lustre/lustre/include/lustre_debug.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@
4545
#include <lustre_net.h>
4646
#include <obd.h>
4747

48-
#include <linux/lustre_debug.h>
49-
5048
/* lib/debug.c */
5149
void dump_lniobuf(struct niobuf_local *lnb);
5250
int dump_req(struct ptlrpc_request *req);

drivers/staging/lustre/lustre/llite/vvp_io.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -628,8 +628,11 @@ static int vvp_io_kernel_fault(struct vvp_fault_io *cfio)
628628
cfio->fault.ft_flags = filemap_fault(cfio->ft_vma, vmf);
629629

630630
if (vmf->page) {
631-
LL_CDEBUG_PAGE(D_PAGE, vmf->page, "got addr %p type NOPAGE\n",
632-
vmf->virtual_address);
631+
CDEBUG(D_PAGE,
632+
"page %p map %p index %lu flags %lx count %u priv %0lx: got addr %p type NOPAGE\n",
633+
vmf->page, vmf->page->mapping, vmf->page->index,
634+
(long)vmf->page->flags, page_count(vmf->page),
635+
page_private(vmf->page), vmf->virtual_address);
633636
if (unlikely(!(cfio->fault.ft_flags & VM_FAULT_LOCKED))) {
634637
lock_page(vmf->page);
635638
cfio->fault.ft_flags &= VM_FAULT_LOCKED;

drivers/staging/lustre/lustre/osc/osc_request.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,8 +1193,12 @@ static obd_count osc_checksum_bulk(int nob, obd_count pg_count,
11931193
cfs_crypto_hash_update_page(hdesc, pga[i]->pg,
11941194
pga[i]->off & ~CFS_PAGE_MASK,
11951195
count);
1196-
LL_CDEBUG_PAGE(D_PAGE, pga[i]->pg, "off %d\n",
1197-
(int)(pga[i]->off & ~CFS_PAGE_MASK));
1196+
CDEBUG(D_PAGE,
1197+
"page %p map %p index %lu flags %lx count %u priv %0lx: off %d\n",
1198+
pga[i]->pg, pga[i]->pg->mapping, pga[i]->pg->index,
1199+
(long)pga[i]->pg->flags, page_count(pga[i]->pg),
1200+
page_private(pga[i]->pg),
1201+
(int)(pga[i]->off & ~CFS_PAGE_MASK));
11981202

11991203
nob -= pga[i]->count;
12001204
pg_count--;

0 commit comments

Comments
 (0)