Skip to content

Commit aa8b187

Browse files
committed
hwmon: (it87) Features mask must be 32 bit wide
Coverity reports: result_independent_of_operands: data->features & (65536UL /* 1UL << 16 */) is always 0 regardless of the values of its operands. This occurs as the logical operand of if. data->features needs to be 32 bit wide since there are more than 16 features. Fixes: cc18da7 ("hwmon: (it87) Support up to 6 temperature sensors ... "); Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 29b4817 commit aa8b187

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hwmon/it87.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ struct it87_sio_data {
491491
struct it87_data {
492492
const struct attribute_group *groups[7];
493493
enum chips type;
494-
u16 features;
494+
u32 features;
495495
u8 peci_mask;
496496
u8 old_peci_mask;
497497

0 commit comments

Comments
 (0)