memremap: check pfn validity before passing to pfn_to_page()

Ard Biesheuvel · torvalds · commit ac343e882a83 · 2016-03-09T15:43:42.000-08:00
In memremap's helper function try_ram_remap(), we dereference a struct
page pointer that was derived from a PFN that is known to be covered by
a 'System RAM' iomem region, and is thus assumed to be a 'valid' PFN,
i.e., a PFN that has a struct page associated with it and is covered by
the kernel direct mapping.

However, the assumption that there is a 1:1 relation between the System
RAM iomem region and the kernel direct mapping is not universally valid
on all architectures, and on ARM and arm64, 'System RAM' may include
regions for which pfn_valid() returns false.

Generally speaking, both __va() and pfn_to_page() should only ever be
called on PFNs/physical addresses for which pfn_valid() returns true, so
add that check to try_ram_remap().

Signed-off-by: Ard Biesheuvel &lt;ard.biesheuvel@linaro.org&gt;
Cc: Dan Williams &lt;dan.j.williams@intel.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/kernel/memremap.c b/kernel/memremap.c
@@ -29,10 +29,10 @@ __weak void __iomem *ioremap_cache(resource_size_t offset, unsigned long size)
 
 static void *try_ram_remap(resource_size_t offset, size_t size)
 {
-	struct page *page = pfn_to_page(offset >> PAGE_SHIFT);
+	unsigned long pfn = PHYS_PFN(offset);
 
 	/* In the simple case just return the existing linear address */
-	if (!PageHighMem(page))
+	if (pfn_valid(pfn) && !PageHighMem(pfn_to_page(pfn)))
 		return __va(offset);
 	return NULL; /* fallback to ioremap_cache */
 }

Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,10 @@ __weak void __iomem *ioremap_cache(resource_size_t offset, unsigned long size)`
`29`	`29`
`30`	`30`	`static void *try_ram_remap(resource_size_t offset, size_t size)`
`31`	`31`	`{`
`32`		`- struct page *page = pfn_to_page(offset >> PAGE_SHIFT);`
	`32`	`+ unsigned long pfn = PHYS_PFN(offset);`
`33`	`33`
`34`	`34`	`/* In the simple case just return the existing linear address */`
`35`		`- if (!PageHighMem(page))`
	`35`	`+ if (pfn_valid(pfn) && !PageHighMem(pfn_to_page(pfn)))`
`36`	`36`	`return __va(offset);`
`37`	`37`	`return NULL; /* fallback to ioremap_cache */`
`38`	`38`	`}`