Skip to content

Commit afa64a7

Browse files
brgldavem330
authored andcommitted
of: net: kill of_get_nvmem_mac_address()
We've switched all users to nvmem_get_mac_address(). Remove the now dead code. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Rob Herring <robh@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent cce41b8 commit afa64a7

File tree

2 files changed

+0
-45
lines changed

2 files changed

+0
-45
lines changed

drivers/of/of_net.c

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -81,42 +81,3 @@ const void *of_get_mac_address(struct device_node *np)
8181
return of_get_mac_addr(np, "address");
8282
}
8383
EXPORT_SYMBOL(of_get_mac_address);
84-
85-
/**
86-
* Obtain the MAC address from an nvmem provider named 'mac-address' through
87-
* device tree.
88-
* On success, copies the new address into memory pointed to by addr and
89-
* returns 0. Returns a negative error code otherwise.
90-
* @np: Device tree node containing the nvmem-cells phandle
91-
* @addr: Pointer to receive the MAC address using ether_addr_copy()
92-
*/
93-
int of_get_nvmem_mac_address(struct device_node *np, void *addr)
94-
{
95-
struct nvmem_cell *cell;
96-
const void *mac;
97-
size_t len;
98-
int ret;
99-
100-
cell = of_nvmem_cell_get(np, "mac-address");
101-
if (IS_ERR(cell))
102-
return PTR_ERR(cell);
103-
104-
mac = nvmem_cell_read(cell, &len);
105-
106-
nvmem_cell_put(cell);
107-
108-
if (IS_ERR(mac))
109-
return PTR_ERR(mac);
110-
111-
if (len < ETH_ALEN || !is_valid_ether_addr(mac)) {
112-
ret = -EINVAL;
113-
} else {
114-
ether_addr_copy(addr, mac);
115-
ret = 0;
116-
}
117-
118-
kfree(mac);
119-
120-
return ret;
121-
}
122-
EXPORT_SYMBOL(of_get_nvmem_mac_address);

include/linux/of_net.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
struct net_device;
1414
extern int of_get_phy_mode(struct device_node *np);
1515
extern const void *of_get_mac_address(struct device_node *np);
16-
extern int of_get_nvmem_mac_address(struct device_node *np, void *addr);
1716
extern struct net_device *of_find_net_device_by_node(struct device_node *np);
1817
#else
1918
static inline int of_get_phy_mode(struct device_node *np)
@@ -26,11 +25,6 @@ static inline const void *of_get_mac_address(struct device_node *np)
2625
return NULL;
2726
}
2827

29-
static inline int of_get_nvmem_mac_address(struct device_node *np, void *addr)
30-
{
31-
return -ENODEV;
32-
}
33-
3428
static inline struct net_device *of_find_net_device_by_node(struct device_node *np)
3529
{
3630
return NULL;

0 commit comments

Comments
 (0)