net: hns: fix skb->truesize underestimation

Huazhong Tan · davem330 · commit b1ccd4c0ab6e · 2018-08-22T21:47:36.000-07:00
skb->truesize is not meant to be tracking amount of used bytes in a skb, but amount of reserved/consumed bytes in memory. For instance, if we use a single byte in last page fragment, we have to account the full size of the fragment. So skb_add_rx_frag needs to calculate the length of the entire buffer into turesize. Fixes: 9cbe9fd ("net: hns: optimize XGE capability by reducing cpu usage") Signed-off-by: Huazhong tan <tanhuazhong@huawei.com> Signed-off-by: Salil Mehta <salil.mehta@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -531,7 +531,7 @@ static void hns_nic_reuse_page(struct sk_buff *skb, int i,
 	}
 
 	skb_add_rx_frag(skb, i, desc_cb->priv, desc_cb->page_offset + pull_len,
-			size - pull_len, truesize - pull_len);
+			size - pull_len, truesize);
 
 	 /* avoid re-using remote pages,flag default unreuse */
 	if (unlikely(page_to_nid(desc_cb->priv) != numa_node_id()))

Original file line number	Diff line number	Diff line change
`@@ -531,7 +531,7 @@ static void hns_nic_reuse_page(struct sk_buff *skb, int i,`
`531`	`531`	`}`
`532`	`532`
`533`	`533`	`skb_add_rx_frag(skb, i, desc_cb->priv, desc_cb->page_offset + pull_len,`
`534`		`- size - pull_len, truesize - pull_len);`
	`534`	`+ size - pull_len, truesize);`
`535`	`535`
`536`	`536`	`/* avoid re-using remote pages,flag default unreuse */`
`537`	`537`	`if (unlikely(page_to_nid(desc_cb->priv) != numa_node_id()))`