Smack: Mark expected switch fall-through

GustavoARSilva · cschaufler · commit b1fed3edc82a · 2018-09-18T16:28:54.000-07:00
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced "No break" with a
proper "Fall through" annotation, which is what GCC is expecting
to find.

Warning level 2 was used: -Wimplicit-fallthrough=2

Addresses-Coverity-ID: 115051 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva &lt;gustavo@embeddedor.com&gt;
Signed-off-by: Casey Schaufler &lt;casey@schaufler-ca.com&gt;
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
@@ -3474,7 +3474,7 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)
 		 */
 		final = &smack_known_star;
 		/*
-		 * No break.
+		 * Fall through.
 		 *
 		 * If a smack value has been set we want to use it,
 		 * but since tmpfs isn't giving us the opportunity

Original file line number	Diff line number	Diff line change
`@@ -3474,7 +3474,7 @@ static void smack_d_instantiate(struct dentry opt_dentry, struct inode inode)`
`3474`	`3474`	`*/`
`3475`	`3475`	`final = &smack_known_star;`
`3476`	`3476`	`/*`
`3477`		`- * No break.`
	`3477`	`+ * Fall through.`
`3478`	`3478`	`*`
`3479`	`3479`	`* If a smack value has been set we want to use it,`
`3480`	`3480`	`* but since tmpfs isn't giving us the opportunity`