Skip to content

Commit b7cffc1

Browse files
vapiertorvalds
authored andcommitted
asm-{alpha,h8300,um,v850,xtensa}/param.h: unbreak HZ for userspace
I noticed this because alpha was broken due to the recent commit commit bdc8078 ("avoid overflows in kernel/time.c"). Most arches do something like this in their asm/param.h: #ifdef __KERNEL__ # define HZ CONFIG_HZ #else # define HZ 100 #endif A few arches though (namely alpha/h8300/um/v850/xtensa) either do no set HZ at all for !__KERNEL__, or they set it wrongly. This should bring all arches in line by setting up HZ for userspace. Without this currently perl 5.10 doesn't build on alpha: perl.c: In function 'perl_construct': perl.c:388: error: 'CONFIG_HZ' undeclared (first use in this function) -> http://buildd.debian.org/fetch.cgi?pkg=perl;ver=5.10.0-10;arch=alpha;stamp=1210252894 Signed-off-by: Mike Frysinger <vapier@gentoo.org> Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Jeff Dike <jdike@addtoit.com> Cc: Chris Zankel <chris@zankel.net> Cc: maximilian attems <max@stro.at> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> [ HZ on alpha is 1024 for historical reasons. - Linus ] Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 772279c commit b7cffc1

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

include/asm-alpha/param.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,12 @@
55
hardware ignores reprogramming. We also need userland buy-in to the
66
change in HZ, since this is visible in the wait4 resources etc. */
77

8+
#ifdef __KERNEL__
89
#define HZ CONFIG_HZ
910
#define USER_HZ HZ
11+
#else
12+
#define HZ 1024
13+
#endif
1014

1115
#define EXEC_PAGESIZE 8192
1216

include/asm-h8300/param.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
#ifndef _H8300_PARAM_H
22
#define _H8300_PARAM_H
33

4-
5-
#ifndef HZ
6-
#define HZ CONFIG_HZ
7-
#endif
8-
94
#ifdef __KERNEL__
5+
#define HZ CONFIG_HZ
106
#define USER_HZ HZ
117
#define CLOCKS_PER_SEC (USER_HZ)
8+
#else
9+
#define HZ 100
1210
#endif
1311

1412
#define EXEC_PAGESIZE 4096

include/asm-um/param.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
#define HZ CONFIG_HZ
1414
#define USER_HZ 100 /* .. some user interfaces are in "ticks" */
1515
#define CLOCKS_PER_SEC (USER_HZ) /* frequency at which times() counts */
16+
#else
17+
#define HZ 100
1618
#endif
1719

1820
#endif

include/asm-v850/param.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
# define HZ CONFIG_HZ
2727
# define USER_HZ 100
2828
# define CLOCKS_PER_SEC USER_HZ
29+
#else
30+
# define HZ 100
2931
#endif
3032

3133
#endif /* __V850_PARAM_H__ */

include/asm-xtensa/param.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
# define HZ CONFIG_HZ /* internal timer frequency */
1616
# define USER_HZ 100 /* for user interfaces in "ticks" */
1717
# define CLOCKS_PER_SEC (USER_HZ) /* frequnzy at which times() counts */
18+
#else
19+
# define HZ 100
1820
#endif
1921

2022
#define EXEC_PAGESIZE 4096

0 commit comments

Comments
 (0)