Skip to content

Commit ba03854

Browse files
Keerthyjvireshk
authored andcommitted
opp: ti-opp-supply: Dynamically update u_volt_min
The voltage range (min, max) provided in the device tree is from the data manual and is pretty big, catering to a wide range of devices. On a i2c read/write failure the regulator_set_voltage_triplet function falls back to set voltage between min and max. The min value from Device Tree can be lesser than the optimal value and in that case that can lead to a hang or crash. Hence set the u_volt_min dynamically to the optimal voltage value. Cc: 4.16+ <stable@vger.kernel.org> # v4.16+ Fixes: 9a835fa ("PM / OPP: Add ti-opp-supply driver") Signed-off-by: Keerthy <j-keerthy@ti.com> Acked-by: Dave Gerlach <d-gerlach@ti.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
1 parent 6510223 commit ba03854

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/opp/ti-opp-supply.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,9 @@ static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
290290
vdd_uv = _get_optimal_vdd_voltage(dev, &opp_data,
291291
new_supply_vbb->u_volt);
292292

293+
if (new_supply_vdd->u_volt_min < vdd_uv)
294+
new_supply_vdd->u_volt_min = vdd_uv;
295+
293296
/* Scaling up? Scale voltage before frequency */
294297
if (freq > old_freq) {
295298
ret = _opp_set_voltage(dev, new_supply_vdd, vdd_uv, vdd_reg,

0 commit comments

Comments
 (0)