net/mlx4_en: Fix setting initial MAC address

Yan Burman · davem330 · commit bab6a9eac053 · 2013-04-02T12:07:56.000-04:00
Commit 6bbb6d9 "net/mlx4_en: Optimize Rx fast path filter checks" introduced a regression
under which the MAC address read from the card was not converted correctly
(the most significant byte was not handled), fix that.

Reviewed-by: Or Gerlitz &lt;ogerlitz@mellanox.com&gt;
Signed-off-by: Yan Burman &lt;yanb@mellanox.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -411,8 +411,8 @@ static int mlx4_en_vlan_rx_kill_vid(struct net_device *dev, unsigned short vid)
 
 static void mlx4_en_u64_to_mac(unsigned char dst_mac[ETH_ALEN + 2], u64 src_mac)
 {
-	unsigned int i;
-	for (i = ETH_ALEN - 1; i; --i) {
+	int i;
+	for (i = ETH_ALEN - 1; i >= 0; --i) {
 		dst_mac[i] = src_mac & 0xff;
 		src_mac >>= 8;
 	}

Original file line number	Diff line number	Diff line change
`@@ -411,8 +411,8 @@ static int mlx4_en_vlan_rx_kill_vid(struct net_device *dev, unsigned short vid)`
`411`	`411`
`412`	`412`	`static void mlx4_en_u64_to_mac(unsigned char dst_mac[ETH_ALEN + 2], u64 src_mac)`
`413`	`413`	`{`
`414`		`- unsigned int i;`
`415`		`- for (i = ETH_ALEN - 1; i; --i) {`
	`414`	`+ int i;`
	`415`	`+ for (i = ETH_ALEN - 1; i >= 0; --i) {`
`416`	`416`	`dst_mac[i] = src_mac & 0xff;`
`417`	`417`	`src_mac >>= 8;`
`418`	`418`	`}`