9p/net: fix memory leak in p9_client_create

zhengbin13 · Dominique Martinet · commit bb06c388fa20 · 2019-03-13T11:50:04.000+01:00
If msize is less than 4096, we should close and put trans, destroy tagpool, not just free client. This patch fixes that. Link: http://lkml.kernel.org/m/1552464097-142659-1-git-send-email-zhengbin13@huawei.com Cc: stable@vger.kernel.org Fixes: 574d356 ("9p/net: put a lower bound on msize") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: zhengbin <zhengbin13@huawei.com> Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
diff --git a/net/9p/client.c b/net/9p/client.c
@@ -1061,7 +1061,7 @@ struct p9_client *p9_client_create(const char *dev_name, char *options)
 		p9_debug(P9_DEBUG_ERROR,
 			 "Please specify a msize of at least 4k\n");
 		err = -EINVAL;
-		goto free_client;
+		goto close_trans;
 	}
 
 	err = p9_client_version(clnt);

Original file line number	Diff line number	Diff line change
`@@ -1061,7 +1061,7 @@ struct p9_client p9_client_create(const char dev_name, char *options)`
`1061`	`1061`	`p9_debug(P9_DEBUG_ERROR,`
`1062`	`1062`	`"Please specify a msize of at least 4k\n");`
`1063`	`1063`	`err = -EINVAL;`
`1064`		`- goto free_client;`
	`1064`	`+ goto close_trans;`
`1065`	`1065`	`}`
`1066`	`1066`
`1067`	`1067`	`err = p9_client_version(clnt);`