serial: ar933x_uart: Fix off-by-one for checking valid alias id

AxelLin · gregkh · commit bb8478d7d676 · 2015-03-07T03:20:25.000+01:00
Current code uses the alias id as array subscript of ar933x_console_ports.
So the valid id is 0 ... CONFIG_SERIAL_AR933X_NR_UARTS - 1.

Signed-off-by: Axel Lin &lt;axel.lin@ingics.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/tty/serial/ar933x_uart.c b/drivers/tty/serial/ar933x_uart.c
@@ -649,7 +649,7 @@ static int ar933x_uart_probe(struct platform_device *pdev)
 			id = 0;
 	}
 
-	if (id > CONFIG_SERIAL_AR933X_NR_UARTS)
+	if (id >= CONFIG_SERIAL_AR933X_NR_UARTS)
 		return -EINVAL;
 
 	irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);

Original file line number	Diff line number	Diff line change
`@@ -649,7 +649,7 @@ static int ar933x_uart_probe(struct platform_device *pdev)`
`649`	`649`	`id = 0;`
`650`	`650`	`}`
`651`	`651`
`652`		`- if (id > CONFIG_SERIAL_AR933X_NR_UARTS)`
	`652`	`+ if (id >= CONFIG_SERIAL_AR933X_NR_UARTS)`
`653`	`653`	`return -EINVAL;`
`654`	`654`
`655`	`655`	`irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);`