drm/i915: make quirks more verbose

danvet · danvet · commit bc0daf488fc4 · 2012-04-09T18:04:09.000+02:00
And add informational dmesg output where it does not yet exist.

In case a quirk matches too much, this information is crucial for
debugging such a bug report.

Reviewed-by: Chris Wilson &lt;chris@chris-wilson.co.uk&gt;
Signed-Off-by: Daniel Vetter &lt;daniel.vetter@ffwll.ch&gt;
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
@@ -545,7 +545,7 @@ static const struct drm_encoder_funcs intel_crt_enc_funcs = {
 
 static int __init intel_no_crt_dmi_callback(const struct dmi_system_id *id)
 {
-	DRM_DEBUG_KMS("Skipping CRT initialization for %s\n", id->ident);
+	DRM_INFO("Skipping CRT initialization for %s\n", id->ident);
 	return 1;
 }
 
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
@@ -9362,7 +9362,7 @@ static void quirk_pipea_force(struct drm_device *dev)
 	struct drm_i915_private *dev_priv = dev->dev_private;
 
 	dev_priv->quirks |= QUIRK_PIPEA_FORCE;
-	DRM_DEBUG_DRIVER("applying pipe a force quirk\n");
+	DRM_INFO("applying pipe a force quirk\n");
 }
 
 /*
@@ -9372,6 +9372,7 @@ static void quirk_ssc_force_disable(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	dev_priv->quirks |= QUIRK_LVDS_SSC_DISABLE;
+	DRM_INFO("applying lvds SSC disable quirk\n");
 }
 
 /*
@@ -9382,6 +9383,7 @@ static void quirk_invert_brightness(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	dev_priv->quirks |= QUIRK_INVERT_BRIGHTNESS;
+	DRM_INFO("applying inverted panel brightness quirk\n");
 }
 
 struct intel_quirk {
diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
@@ -474,7 +474,7 @@ static int intel_lvds_get_modes(struct drm_connector *connector)
 
 static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
 {
-	DRM_DEBUG_KMS("Skipping forced modeset for %s\n", id->ident);
+	DRM_INFO("Skipping forced modeset for %s\n", id->ident);
 	return 1;
 }
 
@@ -622,7 +622,7 @@ static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
 
 static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
 {
-	DRM_DEBUG_KMS("Skipping LVDS initialization for %s\n", id->ident);
+	DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
 	return 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -545,7 +545,7 @@ static const struct drm_encoder_funcs intel_crt_enc_funcs = {`
`545`	`545`
`546`	`546`	`static int __init intel_no_crt_dmi_callback(const struct dmi_system_id *id)`
`547`	`547`	`{`
`548`		`- DRM_DEBUG_KMS("Skipping CRT initialization for %s\n", id->ident);`
	`548`	`+ DRM_INFO("Skipping CRT initialization for %s\n", id->ident);`
`549`	`549`	`return 1;`
`550`	`550`	`}`
`551`	`551`
Original file line number	Diff line number	Diff line change
`@@ -9362,7 +9362,7 @@ static void quirk_pipea_force(struct drm_device *dev)`
`9362`	`9362`	`struct drm_i915_private *dev_priv = dev->dev_private;`
`9363`	`9363`
`9364`	`9364`	`dev_priv->quirks \|= QUIRK_PIPEA_FORCE;`
`9365`		`- DRM_DEBUG_DRIVER("applying pipe a force quirk\n");`
	`9365`	`+ DRM_INFO("applying pipe a force quirk\n");`
`9366`	`9366`	`}`
`9367`	`9367`
`9368`	`9368`	`/*`
`@@ -9372,6 +9372,7 @@ static void quirk_ssc_force_disable(struct drm_device *dev)`
`9372`	`9372`	`{`
`9373`	`9373`	`struct drm_i915_private *dev_priv = dev->dev_private;`
`9374`	`9374`	`dev_priv->quirks \|= QUIRK_LVDS_SSC_DISABLE;`
	`9375`	`+ DRM_INFO("applying lvds SSC disable quirk\n");`
`9375`	`9376`	`}`
`9376`	`9377`
`9377`	`9378`	`/*`
`@@ -9382,6 +9383,7 @@ static void quirk_invert_brightness(struct drm_device *dev)`
`9382`	`9383`	`{`
`9383`	`9384`	`struct drm_i915_private *dev_priv = dev->dev_private;`
`9384`	`9385`	`dev_priv->quirks \|= QUIRK_INVERT_BRIGHTNESS;`
	`9386`	`+ DRM_INFO("applying inverted panel brightness quirk\n");`
`9385`	`9387`	`}`
`9386`	`9388`
`9387`	`9389`	`struct intel_quirk {`
Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ static int intel_lvds_get_modes(struct drm_connector *connector)`
`474`	`474`
`475`	`475`	`static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)`
`476`	`476`	`{`
`477`		`- DRM_DEBUG_KMS("Skipping forced modeset for %s\n", id->ident);`
	`477`	`+ DRM_INFO("Skipping forced modeset for %s\n", id->ident);`
`478`	`478`	`return 1;`
`479`	`479`	`}`
`480`	`480`
`@@ -622,7 +622,7 @@ static const struct drm_encoder_funcs intel_lvds_enc_funcs = {`
`622`	`622`
`623`	`623`	`static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)`
`624`	`624`	`{`
`625`		`- DRM_DEBUG_KMS("Skipping LVDS initialization for %s\n", id->ident);`
	`625`	`+ DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);`
`626`	`626`	`return 1;`
`627`	`627`	`}`
`628`	`628`