NET: phy_device, fix lock imbalance

jirislaby · davem330 · commit bc23283c7bc9 · 2009-07-14T12:03:39.000-07:00
Don't forget to unlock a mutex in phy_scan_fixups on a fail path.

Signed-off-by: Jiri Slaby &lt;jirislaby@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
@@ -134,8 +134,10 @@ int phy_scan_fixups(struct phy_device *phydev)
 
 			err = fixup->run(phydev);
 
-			if (err < 0)
+			if (err < 0) {
+				mutex_unlock(&phy_fixup_lock);
 				return err;
+			}
 		}
 	}
 	mutex_unlock(&phy_fixup_lock);

Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,10 @@ int phy_scan_fixups(struct phy_device *phydev)`
`134`	`134`
`135`	`135`	`err = fixup->run(phydev);`
`136`	`136`
`137`		`- if (err < 0)`
	`137`	`+ if (err < 0) {`
	`138`	`+ mutex_unlock(&phy_fixup_lock);`
`138`	`139`	`return err;`
	`140`	`+ }`
`139`	`141`	`}`
`140`	`142`	`}`
`141`	`143`	`mutex_unlock(&phy_fixup_lock);`