Skip to content

Commit bc7135b

Browse files
rodrigovivimikuint
authored andcommitted
drm/i915: Introduce Kabypoint PCH for Kabylake H/DT.
Some Kabylake SKUs are going to use Kabypoint PCH. It is mainly for Halo and DT ones. >From our specs it doesn't seem that KBP brings any change on the display south engine. So let's consider this as a continuation of SunrisePoint, i.e., SPT+. Since it is easy to get confused by a letter change: KBL = Kabylake - CPU/GPU codename. KBP = Kabypoint - PCH codename. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96826 Link: http://patchwork.freedesktop.org/patch/msgid/1467418032-15167-1-git-send-email-rodrigo.vivi@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (cherry picked from commit 22dea0b) Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
1 parent 12be73a commit bc7135b

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

drivers/gpu/drm/i915/i915_drv.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,10 @@ void intel_detect_pch(struct drm_device *dev)
512512
DRM_DEBUG_KMS("Found SunrisePoint LP PCH\n");
513513
WARN_ON(!IS_SKYLAKE(dev) &&
514514
!IS_KABYLAKE(dev));
515+
} else if (id == INTEL_PCH_KBP_DEVICE_ID_TYPE) {
516+
dev_priv->pch_type = PCH_KBP;
517+
DRM_DEBUG_KMS("Found KabyPoint PCH\n");
518+
WARN_ON(!IS_KABYLAKE(dev));
515519
} else if ((id == INTEL_PCH_P2X_DEVICE_ID_TYPE) ||
516520
(id == INTEL_PCH_P3X_DEVICE_ID_TYPE) ||
517521
((id == INTEL_PCH_QEMU_DEVICE_ID_TYPE) &&

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -990,6 +990,7 @@ enum intel_pch {
990990
PCH_CPT, /* Cougarpoint PCH */
991991
PCH_LPT, /* Lynxpoint PCH */
992992
PCH_SPT, /* Sunrisepoint PCH */
993+
PCH_KBP, /* Kabypoint PCH */
993994
PCH_NOP,
994995
};
995996

@@ -2717,11 +2718,13 @@ struct drm_i915_cmd_table {
27172718
#define INTEL_PCH_LPT_LP_DEVICE_ID_TYPE 0x9c00
27182719
#define INTEL_PCH_SPT_DEVICE_ID_TYPE 0xA100
27192720
#define INTEL_PCH_SPT_LP_DEVICE_ID_TYPE 0x9D00
2721+
#define INTEL_PCH_KBP_DEVICE_ID_TYPE 0xA200
27202722
#define INTEL_PCH_P2X_DEVICE_ID_TYPE 0x7100
27212723
#define INTEL_PCH_P3X_DEVICE_ID_TYPE 0x7000
27222724
#define INTEL_PCH_QEMU_DEVICE_ID_TYPE 0x2900 /* qemu q35 has 2918 */
27232725

27242726
#define INTEL_PCH_TYPE(dev) (__I915__(dev)->pch_type)
2727+
#define HAS_PCH_KBP(dev) (INTEL_PCH_TYPE(dev) == PCH_KBP)
27252728
#define HAS_PCH_SPT(dev) (INTEL_PCH_TYPE(dev) == PCH_SPT)
27262729
#define HAS_PCH_LPT(dev) (INTEL_PCH_TYPE(dev) == PCH_LPT)
27272730
#define HAS_PCH_LPT_LP(dev) (__I915__(dev)->pch_id == INTEL_PCH_LPT_LP_DEVICE_ID_TYPE)

drivers/gpu/drm/i915/i915_irq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2471,7 +2471,7 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl)
24712471
I915_WRITE(SDEIIR, iir);
24722472
ret = IRQ_HANDLED;
24732473

2474-
if (HAS_PCH_SPT(dev_priv))
2474+
if (HAS_PCH_SPT(dev_priv) || HAS_PCH_KBP(dev_priv))
24752475
spt_irq_handler(dev, iir);
24762476
else
24772477
cpt_irq_handler(dev, iir);
@@ -4661,7 +4661,7 @@ void intel_irq_init(struct drm_i915_private *dev_priv)
46614661
dev->driver->disable_vblank = gen8_disable_vblank;
46624662
if (IS_BROXTON(dev))
46634663
dev_priv->display.hpd_irq_setup = bxt_hpd_irq_setup;
4664-
else if (HAS_PCH_SPT(dev))
4664+
else if (HAS_PCH_SPT(dev) || HAS_PCH_KBP(dev))
46654665
dev_priv->display.hpd_irq_setup = spt_hpd_irq_setup;
46664666
else
46674667
dev_priv->display.hpd_irq_setup = ilk_hpd_irq_setup;

drivers/gpu/drm/i915/intel_panel.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1731,7 +1731,8 @@ intel_panel_init_backlight_funcs(struct intel_panel *panel)
17311731
panel->backlight.set = bxt_set_backlight;
17321732
panel->backlight.get = bxt_get_backlight;
17331733
panel->backlight.hz_to_pwm = bxt_hz_to_pwm;
1734-
} else if (HAS_PCH_LPT(dev_priv) || HAS_PCH_SPT(dev_priv)) {
1734+
} else if (HAS_PCH_LPT(dev_priv) || HAS_PCH_SPT(dev_priv) ||
1735+
HAS_PCH_KBP(dev_priv)) {
17351736
panel->backlight.setup = lpt_setup_backlight;
17361737
panel->backlight.enable = lpt_enable_backlight;
17371738
panel->backlight.disable = lpt_disable_backlight;

0 commit comments

Comments
 (0)