PM: suspend: move from strlcpy() with unused retval to strscpy()

Wolfram Sang · rafaeljw · commit bd8092def983 · 2022-08-31T21:15:56.000+02:00
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/include/linux/suspend.h b/include/linux/suspend.h
@@ -75,7 +75,7 @@ extern struct suspend_stats suspend_stats;
 
 static inline void dpm_save_failed_dev(const char *name)
 {
-	strlcpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
+	strscpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
 		name,
 		sizeof(suspend_stats.failed_devs[0]));
 	suspend_stats.last_failed_dev++;

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ extern struct suspend_stats suspend_stats;`
`75`	`75`
`76`	`76`	`static inline void dpm_save_failed_dev(const char *name)`
`77`	`77`	`{`
`78`		`- strlcpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],`
	`78`	`+ strscpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],`
`79`	`79`	`name,`
`80`	`80`	`sizeof(suspend_stats.failed_devs[0]));`
`81`	`81`	`suspend_stats.last_failed_dev++;`