drm/nv50/disp: min/max are reversed in nv50_crtc_gamma_set()

Dan Carpenter · Ben Skeggs · commit bdefc8cbdfc7 · 2013-12-03T23:28:58.000+10:00
We should be taking the minimum here instead of the max. It could lead to a buffer overflow. Fixes: 438d99e ('drm/nvd0/disp: initial crtc object implementation') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> a/drm/nv50_display.c b/drm/nv50_display.c index f8e66c0..4e384a2 100644
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
@@ -1265,7 +1265,7 @@ nv50_crtc_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b,
 		    uint32_t start, uint32_t size)
 {
 	struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-	u32 end = max(start + size, (u32)256);
+	u32 end = min_t(u32, start + size, 256);
 	u32 i;
 
 	for (i = start; i < end; i++) {

Original file line number	Diff line number	Diff line change
`@@ -1265,7 +1265,7 @@ nv50_crtc_gamma_set(struct drm_crtc crtc, u16 r, u16 g, u16 b,`
`1265`	`1265`	`uint32_t start, uint32_t size)`
`1266`	`1266`	`{`
`1267`	`1267`	`struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);`
`1268`		`- u32 end = max(start + size, (u32)256);`
	`1268`	`+ u32 end = min_t(u32, start + size, 256);`
`1269`	`1269`	`u32 i;`
`1270`	`1270`
`1271`	`1271`	`for (i = start; i < end; i++) {`