iio: dummy: events: Add missing break

larsclausen · jic23 · commit be94a6f6d488 · 2017-10-01T11:17:18.000+01:00
Add missing break in iio_simple_dummy_write_event_config() for the voltage threshold event enable attribute. Without this writing to the in_voltage0_thresh_rising_en always returns -EINVAL even though the change was correctly applied. Fixes: 3e34e65 ("iio: dummy: Demonstrate the usage of new channel types") Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
diff --git a/drivers/iio/dummy/iio_simple_dummy_events.c b/drivers/iio/dummy/iio_simple_dummy_events.c
@@ -72,6 +72,7 @@ int iio_simple_dummy_write_event_config(struct iio_dev *indio_dev,
 				st->event_en = state;
 			else
 				return -EINVAL;
+			break;
 		default:
 			return -EINVAL;
 		}

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ int iio_simple_dummy_write_event_config(struct iio_dev *indio_dev,`
`72`	`72`	`st->event_en = state;`
`73`	`73`	`else`
`74`	`74`	`return -EINVAL;`
	`75`	`+ break;`
`75`	`76`	`default:`
`76`	`77`	`return -EINVAL;`
`77`	`78`	`}`