Skip to content

Commit bf4e890

Browse files
dkipertorvalds
authored andcommitted
mm: enable set_page_section() only if CONFIG_SPARSEMEM and !CONFIG_SPARSEMEM_VMEMMAP
set_page_section() is meaningful only in CONFIG_SPARSEMEM and !CONFIG_SPARSEMEM_VMEMMAP context. Move it to proper place and amend accordingly functions which are using it. Signed-off-by: Daniel Kiper <dkiper@net-space.pl> Acked-by: Dave Hansen <dave@linux.vnet.ibm.com> Acked-by: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a3bc42f commit bf4e890

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

include/linux/mm.h

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -682,6 +682,12 @@ static inline struct zone *page_zone(struct page *page)
682682
}
683683

684684
#if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
685+
static inline void set_page_section(struct page *page, unsigned long section)
686+
{
687+
page->flags &= ~(SECTIONS_MASK << SECTIONS_PGSHIFT);
688+
page->flags |= (section & SECTIONS_MASK) << SECTIONS_PGSHIFT;
689+
}
690+
685691
static inline unsigned long page_to_section(struct page *page)
686692
{
687693
return (page->flags >> SECTIONS_PGSHIFT) & SECTIONS_MASK;
@@ -700,18 +706,14 @@ static inline void set_page_node(struct page *page, unsigned long node)
700706
page->flags |= (node & NODES_MASK) << NODES_PGSHIFT;
701707
}
702708

703-
static inline void set_page_section(struct page *page, unsigned long section)
704-
{
705-
page->flags &= ~(SECTIONS_MASK << SECTIONS_PGSHIFT);
706-
page->flags |= (section & SECTIONS_MASK) << SECTIONS_PGSHIFT;
707-
}
708-
709709
static inline void set_page_links(struct page *page, enum zone_type zone,
710710
unsigned long node, unsigned long pfn)
711711
{
712712
set_page_zone(page, zone);
713713
set_page_node(page, node);
714+
#if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
714715
set_page_section(page, pfn_to_section_nr(pfn));
716+
#endif
715717
}
716718

717719
/*

0 commit comments

Comments
 (0)