Skip to content

Commit bf567dd

Browse files
andy-shevrafaeljw
authored andcommitted
ACPI / configfs: Mark local data structures static
There is no need to have non-static local data structures. otherwise sparse is not happy: CHECK drivers/acpi/acpi_configfs.c drivers/acpi/acpi_configfs.c:100:31: warning: symbol 'acpi_table_bin_attrs' was not declared. Should it be static? drivers/acpi/acpi_configfs.c:196:27: warning: symbol 'acpi_table_attrs' was not declared. Should it be static? drivers/acpi/acpi_configfs.c:236:34: warning: symbol 'acpi_table_group_ops' was not declared. Should it be static? Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent c62c15a commit bf567dd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/acpi/acpi_configfs.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ static ssize_t acpi_table_aml_read(struct config_item *cfg,
9797

9898
CONFIGFS_BIN_ATTR(acpi_table_, aml, NULL, MAX_ACPI_TABLE_SIZE);
9999

100-
struct configfs_bin_attribute *acpi_table_bin_attrs[] = {
100+
static struct configfs_bin_attribute *acpi_table_bin_attrs[] = {
101101
&acpi_table_attr_aml,
102102
NULL,
103103
};
@@ -193,7 +193,7 @@ CONFIGFS_ATTR_RO(acpi_table_, oem_revision);
193193
CONFIGFS_ATTR_RO(acpi_table_, asl_compiler_id);
194194
CONFIGFS_ATTR_RO(acpi_table_, asl_compiler_revision);
195195

196-
struct configfs_attribute *acpi_table_attrs[] = {
196+
static struct configfs_attribute *acpi_table_attrs[] = {
197197
&acpi_table_attr_signature,
198198
&acpi_table_attr_length,
199199
&acpi_table_attr_revision,
@@ -233,7 +233,7 @@ static void acpi_table_drop_item(struct config_group *group,
233233
acpi_tb_unload_table(table->index);
234234
}
235235

236-
struct configfs_group_operations acpi_table_group_ops = {
236+
static struct configfs_group_operations acpi_table_group_ops = {
237237
.make_item = acpi_table_make_item,
238238
.drop_item = acpi_table_drop_item,
239239
};

0 commit comments

Comments
 (0)