Skip to content

Commit c04e553

Browse files
robherringsuryasaimadhu
authored andcommitted
x86/platform/olpc: Do not call of_platform_bus_probe()
The DT core will probe the DT by default now, so the OLPC platform code calling of_platform_bus_probe() is not necessary. The algorithm for what nodes are probed is a little different in how compatible is handled, but since OLPC uses compatible strings for matching it is not affected by this difference. Also, only the battery node located at the root level gets a device created as the dcon is a PCI device and the RTC device is created in olpc-xo1-rtc.c. Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Borislav Petkov <bp@suse.de> CC: "H. Peter Anvin" <hpa@zytor.com> CC: Ingo Molnar <mingo@redhat.com> CC: Lubomir Rintel <lkundrak@v3.sk> Cc: Thomas Gleixner <tglx@linutronix.de> CC: devicetree@vger.kernel.org CC: x86-ml <x86@kernel.org> Link: http://lkml.kernel.org/r/20181116201820.10065-1-robh@kernel.org
1 parent ccda4af commit c04e553

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

arch/x86/platform/olpc/olpc_dt.c

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include <linux/kernel.h>
2020
#include <linux/memblock.h>
2121
#include <linux/of.h>
22-
#include <linux/of_platform.h>
2322
#include <linux/of_pdt.h>
2423
#include <asm/olpc.h>
2524
#include <asm/olpc_ofw.h>
@@ -285,20 +284,3 @@ void __init olpc_dt_build_devicetree(void)
285284
pr_info("PROM DT: Built device tree with %u bytes of memory.\n",
286285
prom_early_allocated);
287286
}
288-
289-
/* A list of DT node/bus matches that we want to expose as platform devices */
290-
static struct of_device_id __initdata of_ids[] = {
291-
{ .compatible = "olpc,xo1-battery" },
292-
{ .compatible = "olpc,xo1-dcon" },
293-
{ .compatible = "olpc,xo1-rtc" },
294-
{},
295-
};
296-
297-
static int __init olpc_create_platform_devices(void)
298-
{
299-
if (machine_is_olpc())
300-
return of_platform_bus_probe(NULL, of_ids, NULL);
301-
else
302-
return 0;
303-
}
304-
device_initcall(olpc_create_platform_devices);

0 commit comments

Comments
 (0)