net/act_pedit: fix an error code

Dan Carpenter · davem330 · commit c4f65b09b459 · 2017-06-14T15:24:18.000-04:00
I'm reviewing static checker warnings where we do ERR_PTR(0), which is the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) here. Sometimes these bugs lead to a NULL dereference but I don't immediately see that problem here. Fixes: 71d0ed7 ("net/act_pedit: Support using offset relative to the conventional network headers") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Amir Vadai <amir@vadai.me> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
@@ -94,8 +94,10 @@ static struct tcf_pedit_key_ex *tcf_pedit_keys_ex_parse(struct nlattr *nla,
 		k++;
 	}
 
-	if (n)
+	if (n) {
+		err = -EINVAL;
 		goto err_out;
+	}
 
 	return keys_ex;
 

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,10 @@ static struct tcf_pedit_key_ex tcf_pedit_keys_ex_parse(struct nlattr nla,`
`94`	`94`	`k++;`
`95`	`95`	`}`
`96`	`96`
`97`		`- if (n)`
	`97`	`+ if (n) {`
	`98`	`+ err = -EINVAL;`
`98`	`99`	`goto err_out;`
	`100`	`+ }`
`99`	`101`
`100`	`102`	`return keys_ex;`
`101`	`103`