powerpc/8xx: fix cpm_cascade() dual end of interrupt

chleroy · mpe · commit c554ac91ce22 · 2018-03-13T15:50:28.000+11:00
cpm_cascade() doesn't have to call eoi() as it is already called
by handle_fasteoi_irq()

And cpm_get_irq() will always return an unsigned int so the test
is useless

Signed-off-by: Christophe Leroy &lt;christophe.leroy@c-s.fr&gt;
Signed-off-by: Michael Ellerman &lt;mpe@ellerman.id.au&gt;
diff --git a/arch/powerpc/platforms/8xx/m8xx_setup.c b/arch/powerpc/platforms/8xx/m8xx_setup.c
@@ -217,13 +217,7 @@ void __noreturn mpc8xx_restart(char *cmd)
 
 static void cpm_cascade(struct irq_desc *desc)
 {
-	struct irq_chip *chip = irq_desc_get_chip(desc);
-	int cascade_irq = cpm_get_irq();
-
-	if (cascade_irq >= 0)
-		generic_handle_irq(cascade_irq);
-
-	chip->irq_eoi(&desc->irq_data);
+	generic_handle_irq(cpm_get_irq());
 }
 
 /* Initialize the internal interrupt controllers.  The number of

Original file line number	Diff line number	Diff line change
`@@ -217,13 +217,7 @@ void __noreturn mpc8xx_restart(char *cmd)`
`217`	`217`
`218`	`218`	`static void cpm_cascade(struct irq_desc *desc)`
`219`	`219`	`{`
`220`		`- struct irq_chip *chip = irq_desc_get_chip(desc);`
`221`		`- int cascade_irq = cpm_get_irq();`
`222`		`-`
`223`		`- if (cascade_irq >= 0)`
`224`		`- generic_handle_irq(cascade_irq);`
`225`		`-`
`226`		`- chip->irq_eoi(&desc->irq_data);`
	`220`	`+ generic_handle_irq(cpm_get_irq());`
`227`	`221`	`}`
`228`	`222`
`229`	`223`	`/* Initialize the internal interrupt controllers. The number of`