ipc: mqueue: fix possible memory leak in init_mqueue_fs()

HBh25Y · ebiederm · commit c579d60f0d0c · 2022-07-19T17:17:35.000-05:00
commit db7cfc3 ("ipc: Free mq_sysctls if ipc namespace creation failed") Here's a similar memory leak to the one fixed by the patch above. retire_mq_sysctls need to be called when init_mqueue_fs fails after setup_mq_sysctls. Fixes: dc55e35 ("ipc: Store mqueue sysctls in the ipc namespace") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Link: https://lkml.kernel.org/r/20220715062301.19311-1-hbh25y@gmail.com Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
diff --git a/ipc/mqueue.c b/ipc/mqueue.c
@@ -1746,6 +1746,7 @@ static int __init init_mqueue_fs(void)
 	unregister_filesystem(&mqueue_fs_type);
 out_sysctl:
 	kmem_cache_destroy(mqueue_inode_cachep);
+	retire_mq_sysctls(&init_ipc_ns);
 	return error;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1746,6 +1746,7 @@ static int __init init_mqueue_fs(void)`
`1746`	`1746`	`unregister_filesystem(&mqueue_fs_type);`
`1747`	`1747`	`out_sysctl:`
`1748`	`1748`	`kmem_cache_destroy(mqueue_inode_cachep);`
	`1749`	`+ retire_mq_sysctls(&init_ipc_ns);`
`1749`	`1750`	`return error;`
`1750`	`1751`	`}`
`1751`	`1752`