Skip to content

Commit c5ad4f5

Browse files
RoelKluindavem330
authored andcommitted
atl1c: add missing parentheses
Parentheses are required or the comparison occurs before the bitand. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 95aa1fe commit c5ad4f5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/atl1c/atl1c.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,14 +188,14 @@ struct atl1c_tpd_ext_desc {
188188
#define RRS_HDS_TYPE_DATA 2
189189

190190
#define RRS_IS_NO_HDS_TYPE(flag) \
191-
(((flag) >> (RRS_HDS_TYPE_SHIFT)) & RRS_HDS_TYPE_MASK == 0)
191+
((((flag) >> (RRS_HDS_TYPE_SHIFT)) & RRS_HDS_TYPE_MASK) == 0)
192192

193193
#define RRS_IS_HDS_HEAD(flag) \
194-
(((flag) >> (RRS_HDS_TYPE_SHIFT)) & RRS_HDS_TYPE_MASK == \
194+
((((flag) >> (RRS_HDS_TYPE_SHIFT)) & RRS_HDS_TYPE_MASK) == \
195195
RRS_HDS_TYPE_HEAD)
196196

197197
#define RRS_IS_HDS_DATA(flag) \
198-
(((flag) >> (RRS_HDS_TYPE_SHIFT)) & RRS_HDS_TYPE_MASK == \
198+
((((flag) >> (RRS_HDS_TYPE_SHIFT)) & RRS_HDS_TYPE_MASK) == \
199199
RRS_HDS_TYPE_DATA)
200200

201201
/* rrs word 3 bit 0:31 */
@@ -245,7 +245,7 @@ struct atl1c_tpd_ext_desc {
245245
#define RRS_PACKET_TYPE_802_3 1
246246
#define RRS_PACKET_TYPE_ETH 0
247247
#define RRS_PACKET_IS_ETH(word) \
248-
(((word) >> RRS_PACKET_TYPE_SHIFT) & RRS_PACKET_TYPE_MASK == \
248+
((((word) >> RRS_PACKET_TYPE_SHIFT) & RRS_PACKET_TYPE_MASK) == \
249249
RRS_PACKET_TYPE_ETH)
250250
#define RRS_RXD_IS_VALID(word) \
251251
((((word) >> RRS_RXD_UPDATED_SHIFT) & RRS_RXD_UPDATED_MASK) == 1)

0 commit comments

Comments
 (0)