ACPI / configfs: Mark local functions static

andy-shev · rafaeljw · commit c62c15a92455 · 2019-03-12T09:50:56.000+01:00
There is no need to have non-static local functions. otherwise
compiler is not happy:

  CC [M]  drivers/acpi/acpi_configfs.o
drivers/acpi/acpi_configfs.c:105:9: warning: no previous prototype for ‘acpi_table_signature_show’ [-Wmissing-prototypes]
 ssize_t acpi_table_signature_show(struct config_item *cfg, char *str)
         ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/acpi_configfs.c:115:9: warning: no previous prototype for ‘acpi_table_length_show’ [-Wmissing-prototypes]
 ssize_t acpi_table_length_show(struct config_item *cfg, char *str)
         ^~~~~~~~~~~~~~~~~~~~~~
...

Signed-off-by: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/acpi/acpi_configfs.c b/drivers/acpi/acpi_configfs.c
@@ -102,7 +102,7 @@ struct configfs_bin_attribute *acpi_table_bin_attrs[] = {
 	NULL,
 };
 
-ssize_t acpi_table_signature_show(struct config_item *cfg, char *str)
+static ssize_t acpi_table_signature_show(struct config_item *cfg, char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 
@@ -112,7 +112,7 @@ ssize_t acpi_table_signature_show(struct config_item *cfg, char *str)
 	return sprintf(str, "%.*s\n", ACPI_NAME_SIZE, h->signature);
 }
 
-ssize_t acpi_table_length_show(struct config_item *cfg, char *str)
+static ssize_t acpi_table_length_show(struct config_item *cfg, char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 
@@ -122,7 +122,7 @@ ssize_t acpi_table_length_show(struct config_item *cfg, char *str)
 	return sprintf(str, "%d\n", h->length);
 }
 
-ssize_t acpi_table_revision_show(struct config_item *cfg, char *str)
+static ssize_t acpi_table_revision_show(struct config_item *cfg, char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 
@@ -132,7 +132,7 @@ ssize_t acpi_table_revision_show(struct config_item *cfg, char *str)
 	return sprintf(str, "%d\n", h->revision);
 }
 
-ssize_t acpi_table_oem_id_show(struct config_item *cfg, char *str)
+static ssize_t acpi_table_oem_id_show(struct config_item *cfg, char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 
@@ -142,7 +142,7 @@ ssize_t acpi_table_oem_id_show(struct config_item *cfg, char *str)
 	return sprintf(str, "%.*s\n", ACPI_OEM_ID_SIZE, h->oem_id);
 }
 
-ssize_t acpi_table_oem_table_id_show(struct config_item *cfg, char *str)
+static ssize_t acpi_table_oem_table_id_show(struct config_item *cfg, char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 
@@ -152,7 +152,7 @@ ssize_t acpi_table_oem_table_id_show(struct config_item *cfg, char *str)
 	return sprintf(str, "%.*s\n", ACPI_OEM_TABLE_ID_SIZE, h->oem_table_id);
 }
 
-ssize_t acpi_table_oem_revision_show(struct config_item *cfg, char *str)
+static ssize_t acpi_table_oem_revision_show(struct config_item *cfg, char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 
@@ -162,7 +162,8 @@ ssize_t acpi_table_oem_revision_show(struct config_item *cfg, char *str)
 	return sprintf(str, "%d\n", h->oem_revision);
 }
 
-ssize_t acpi_table_asl_compiler_id_show(struct config_item *cfg, char *str)
+static ssize_t acpi_table_asl_compiler_id_show(struct config_item *cfg,
+					       char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 
@@ -172,8 +173,8 @@ ssize_t acpi_table_asl_compiler_id_show(struct config_item *cfg, char *str)
 	return sprintf(str, "%.*s\n", ACPI_NAME_SIZE, h->asl_compiler_id);
 }
 
-ssize_t acpi_table_asl_compiler_revision_show(struct config_item *cfg,
-					      char *str)
+static ssize_t acpi_table_asl_compiler_revision_show(struct config_item *cfg,
+						     char *str)
 {
 	struct acpi_table_header *h = get_header(cfg);
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ struct configfs_bin_attribute *acpi_table_bin_attrs[] = {`
`102`	`102`	`NULL,`
`103`	`103`	`};`
`104`	`104`
`105`		`-ssize_t acpi_table_signature_show(struct config_item cfg, char str)`
	`105`	`+static ssize_t acpi_table_signature_show(struct config_item cfg, char str)`
`106`	`106`	`{`
`107`	`107`	`struct acpi_table_header *h = get_header(cfg);`
`108`	`108`
`@@ -112,7 +112,7 @@ ssize_t acpi_table_signature_show(struct config_item cfg, char str)`
`112`	`112`	`return sprintf(str, "%.*s\n", ACPI_NAME_SIZE, h->signature);`
`113`	`113`	`}`
`114`	`114`
`115`		`-ssize_t acpi_table_length_show(struct config_item cfg, char str)`
	`115`	`+static ssize_t acpi_table_length_show(struct config_item cfg, char str)`
`116`	`116`	`{`
`117`	`117`	`struct acpi_table_header *h = get_header(cfg);`
`118`	`118`
`@@ -122,7 +122,7 @@ ssize_t acpi_table_length_show(struct config_item cfg, char str)`
`122`	`122`	`return sprintf(str, "%d\n", h->length);`
`123`	`123`	`}`
`124`	`124`
`125`		`-ssize_t acpi_table_revision_show(struct config_item cfg, char str)`
	`125`	`+static ssize_t acpi_table_revision_show(struct config_item cfg, char str)`
`126`	`126`	`{`
`127`	`127`	`struct acpi_table_header *h = get_header(cfg);`
`128`	`128`
`@@ -132,7 +132,7 @@ ssize_t acpi_table_revision_show(struct config_item cfg, char str)`
`132`	`132`	`return sprintf(str, "%d\n", h->revision);`
`133`	`133`	`}`
`134`	`134`
`135`		`-ssize_t acpi_table_oem_id_show(struct config_item cfg, char str)`
	`135`	`+static ssize_t acpi_table_oem_id_show(struct config_item cfg, char str)`
`136`	`136`	`{`
`137`	`137`	`struct acpi_table_header *h = get_header(cfg);`
`138`	`138`
`@@ -142,7 +142,7 @@ ssize_t acpi_table_oem_id_show(struct config_item cfg, char str)`
`142`	`142`	`return sprintf(str, "%.*s\n", ACPI_OEM_ID_SIZE, h->oem_id);`
`143`	`143`	`}`
`144`	`144`
`145`		`-ssize_t acpi_table_oem_table_id_show(struct config_item cfg, char str)`
	`145`	`+static ssize_t acpi_table_oem_table_id_show(struct config_item cfg, char str)`
`146`	`146`	`{`
`147`	`147`	`struct acpi_table_header *h = get_header(cfg);`
`148`	`148`
`@@ -152,7 +152,7 @@ ssize_t acpi_table_oem_table_id_show(struct config_item cfg, char str)`
`152`	`152`	`return sprintf(str, "%.*s\n", ACPI_OEM_TABLE_ID_SIZE, h->oem_table_id);`
`153`	`153`	`}`
`154`	`154`
`155`		`-ssize_t acpi_table_oem_revision_show(struct config_item cfg, char str)`
	`155`	`+static ssize_t acpi_table_oem_revision_show(struct config_item cfg, char str)`
`156`	`156`	`{`
`157`	`157`	`struct acpi_table_header *h = get_header(cfg);`
`158`	`158`
`@@ -162,7 +162,8 @@ ssize_t acpi_table_oem_revision_show(struct config_item cfg, char str)`
`162`	`162`	`return sprintf(str, "%d\n", h->oem_revision);`
`163`	`163`	`}`
`164`	`164`
`165`		`-ssize_t acpi_table_asl_compiler_id_show(struct config_item cfg, char str)`
	`165`	`+static ssize_t acpi_table_asl_compiler_id_show(struct config_item *cfg,`
	`166`	`+ char *str)`
`166`	`167`	`{`
`167`	`168`	`struct acpi_table_header *h = get_header(cfg);`
`168`	`169`
`@@ -172,8 +173,8 @@ ssize_t acpi_table_asl_compiler_id_show(struct config_item cfg, char str)`
`172`	`173`	`return sprintf(str, "%.*s\n", ACPI_NAME_SIZE, h->asl_compiler_id);`
`173`	`174`	`}`
`174`	`175`
`175`		`-ssize_t acpi_table_asl_compiler_revision_show(struct config_item *cfg,`
`176`		`- char *str)`
	`176`	`+static ssize_t acpi_table_asl_compiler_revision_show(struct config_item *cfg,`
	`177`	`+ char *str)`
`177`	`178`	`{`
`178`	`179`	`struct acpi_table_header *h = get_header(cfg);`
`179`	`180`