Skip to content

Commit c7badc9

Browse files
htejuntorvalds
authored andcommitted
scsi: use %*pb[l] to print bitmaps including cpumasks and nodemasks
printk and friends can now format bitmaps using '%*pb[l]'. cpumask and nodemask also provide cpumask_pr_args() and nodemask_pr_args() respectively which can be used to generate the two printf arguments necessary to format the specified cpu/nodemask. * map_show()'s return value is too high by one and the function could modify beyond the end of the buffer when the formatted text is long enough. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0b48003 commit c7badc9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/scsi/scsi_debug.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4658,10 +4658,10 @@ static ssize_t map_show(struct device_driver *ddp, char *buf)
46584658
return scnprintf(buf, PAGE_SIZE, "0-%u\n",
46594659
sdebug_store_sectors);
46604660

4661-
count = bitmap_scnlistprintf(buf, PAGE_SIZE, map_storep, map_size);
4662-
4661+
count = scnprintf(buf, PAGE_SIZE - 1, "%*pbl",
4662+
(int)map_size, map_storep);
46634663
buf[count++] = '\n';
4664-
buf[count++] = 0;
4664+
buf[count] = '\0';
46654665

46664666
return count;
46674667
}

0 commit comments

Comments
 (0)