bpf: Annotate implicit fall through in cgroup_dev_func_proto

malaterre · borkmann · commit c8dc79806e7f · 2019-01-17T16:52:23.000+01:00
There is a plan to build the kernel with -Wimplicit-fallthrough
and this place in the code produced a warnings (W=1).

This commit removes the following warning:

  kernel/bpf/cgroup.c:719:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Mathieu Malaterre &lt;malat@debian.org&gt;
Signed-off-by: Daniel Borkmann &lt;daniel@iogearbox.net&gt;
diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c
@@ -718,6 +718,7 @@ cgroup_dev_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
 	case BPF_FUNC_trace_printk:
 		if (capable(CAP_SYS_ADMIN))
 			return bpf_get_trace_printk_proto();
+		/* fall through */
 	default:
 		return NULL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -718,6 +718,7 @@ cgroup_dev_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)`
`718`	`718`	`case BPF_FUNC_trace_printk:`
`719`	`719`	`if (capable(CAP_SYS_ADMIN))`
`720`	`720`	`return bpf_get_trace_printk_proto();`
	`721`	`+ /* fall through */`
`721`	`722`	`default:`
`722`	`723`	`return NULL;`
`723`	`724`	`}`