Skip to content

Commit c99d667

Browse files
anishdavem330
authored andcommitted
cnic : Cleanup CONFIG_IPV6 & VLAN check
The cnic module needs to ensure that if ipv6 support is compiled as a module, then the cnic module cannot be compiled as built-in as it depends on ipv6. Made this check cleaner via Kconfig Use simpler IS_ENABLED for CONFIG_VLAN_8021Q check Signed-off-by: Anish Bhatt <anish@chelsio.com> Acked-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent e793c0f commit c99d667

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/net/ethernet/broadcom/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ config BNX2
8484

8585
config CNIC
8686
tristate "QLogic CNIC support"
87-
depends on PCI
87+
depends on PCI && (IPV6 || IPV6=n)
8888
select BNX2
8989
select UIO
9090
---help---

drivers/net/ethernet/broadcom/cnic.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#include <linux/if_vlan.h>
3232
#include <linux/prefetch.h>
3333
#include <linux/random.h>
34-
#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
34+
#if IS_ENABLED(CONFIG_VLAN_8021Q)
3535
#define BCM_VLAN 1
3636
#endif
3737
#include <net/ip.h>
@@ -3685,7 +3685,7 @@ static int cnic_get_v4_route(struct sockaddr_in *dst_addr,
36853685
static int cnic_get_v6_route(struct sockaddr_in6 *dst_addr,
36863686
struct dst_entry **dst)
36873687
{
3688-
#if defined(CONFIG_IPV6) || (defined(CONFIG_IPV6_MODULE) && defined(MODULE))
3688+
#if IS_ENABLED(CONFIG_IPV6)
36893689
struct flowi6 fl6;
36903690

36913691
memset(&fl6, 0, sizeof(fl6));

0 commit comments

Comments
 (0)