Skip to content

Commit cbbe76c

Browse files
AstralBobAndreas Gruenbacher
authored andcommitted
gfs2: Remove vestigial bd_ops
Field bd_ops was set but never used, so I removed it, and all code supporting it. Signed-off-by: Bob Peterson <rpeterso@redhat.com> Acked-by: Steven Whitehouse <swhiteho@redhat.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
1 parent 2a5f14f commit cbbe76c

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

fs/gfs2/incore.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ struct gfs2_bufdata {
165165
u64 bd_blkno;
166166

167167
struct list_head bd_list;
168-
const struct gfs2_log_operations *bd_ops;
169168

170169
struct gfs2_trans *bd_tr;
171170
struct list_head bd_ail_st_list;

fs/gfs2/log.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,6 @@ void gfs2_add_revoke(struct gfs2_sbd *sdp, struct gfs2_bufdata *bd)
605605
bd->bd_blkno = bh->b_blocknr;
606606
gfs2_remove_from_ail(bd); /* drops ref on bh */
607607
bd->bd_bh = NULL;
608-
bd->bd_ops = &gfs2_revoke_lops;
609608
sdp->sd_log_num_revoke++;
610609
atomic_inc(&gl->gl_revokes);
611610
set_bit(GLF_LFLUSH, &gl->gl_flags);

fs/gfs2/trans.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,15 +124,13 @@ void gfs2_trans_end(struct gfs2_sbd *sdp)
124124
}
125125

126126
static struct gfs2_bufdata *gfs2_alloc_bufdata(struct gfs2_glock *gl,
127-
struct buffer_head *bh,
128-
const struct gfs2_log_operations *lops)
127+
struct buffer_head *bh)
129128
{
130129
struct gfs2_bufdata *bd;
131130

132131
bd = kmem_cache_zalloc(gfs2_bufdata_cachep, GFP_NOFS | __GFP_NOFAIL);
133132
bd->bd_bh = bh;
134133
bd->bd_gl = gl;
135-
bd->bd_ops = lops;
136134
INIT_LIST_HEAD(&bd->bd_list);
137135
bh->b_private = bd;
138136
return bd;
@@ -169,7 +167,7 @@ void gfs2_trans_add_data(struct gfs2_glock *gl, struct buffer_head *bh)
169167
gfs2_log_unlock(sdp);
170168
unlock_buffer(bh);
171169
if (bh->b_private == NULL)
172-
bd = gfs2_alloc_bufdata(gl, bh, &gfs2_databuf_lops);
170+
bd = gfs2_alloc_bufdata(gl, bh);
173171
else
174172
bd = bh->b_private;
175173
lock_buffer(bh);
@@ -210,7 +208,7 @@ void gfs2_trans_add_meta(struct gfs2_glock *gl, struct buffer_head *bh)
210208
unlock_buffer(bh);
211209
lock_page(bh->b_page);
212210
if (bh->b_private == NULL)
213-
bd = gfs2_alloc_bufdata(gl, bh, &gfs2_buf_lops);
211+
bd = gfs2_alloc_bufdata(gl, bh);
214212
else
215213
bd = bh->b_private;
216214
unlock_page(bh->b_page);

0 commit comments

Comments
 (0)