Skip to content

Commit cbe7dfa

Browse files
Christoph Hellwigmartinkpetersen
authored andcommitted
Revert "scsi: default to scsi-mq"
Defaulting to scsi-mq in 4.13-rc has shown various regressions on setups that we didn't previously consider. Fixes for them are in progress, but too invasive to make it in this cycle. So for now revert the commit that defaults to blk-mq for SCSI. For 4.14 we'll plan to try again with these fixes. This reverts commit 5c279bd. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 70e42fd commit cbe7dfa

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

drivers/scsi/Kconfig

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,17 @@ config SCSI_NETLINK
4747
default n
4848
depends on NET
4949

50+
config SCSI_MQ_DEFAULT
51+
bool "SCSI: use blk-mq I/O path by default"
52+
depends on SCSI
53+
---help---
54+
This option enables the new blk-mq based I/O path for SCSI
55+
devices by default. With the option the scsi_mod.use_blk_mq
56+
module/boot option defaults to Y, without it to N, but it can
57+
still be overridden either way.
58+
59+
If unsure say N.
60+
5061
config SCSI_PROC_FS
5162
bool "legacy /proc/scsi/ support"
5263
depends on SCSI && PROC_FS

drivers/scsi/scsi.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,11 @@ MODULE_LICENSE("GPL");
800800
module_param(scsi_logging_level, int, S_IRUGO|S_IWUSR);
801801
MODULE_PARM_DESC(scsi_logging_level, "a bit mask of logging levels");
802802

803+
#ifdef CONFIG_SCSI_MQ_DEFAULT
803804
bool scsi_use_blk_mq = true;
805+
#else
806+
bool scsi_use_blk_mq = false;
807+
#endif
804808
module_param_named(use_blk_mq, scsi_use_blk_mq, bool, S_IWUSR | S_IRUGO);
805809

806810
static int __init init_scsi(void)

0 commit comments

Comments
 (0)