IB/rxe: Drop future atomic/read packets rather than retrying

Andrew Boyer · dledford · commit cbf1f9a46c9c · 2016-12-22T11:36:12.000-05:00
If the completer is in the middle of a large read operation, one
lost packet can cause havoc. Going to COMPST_ERROR_RETRY will
cause the requester to resend the request. After that, any packet
from the first attempt still in the receive queue will be
interpreted as an error, restarting the error/retry sequence.
The transfer will quickly exhaust its retries.

This behavior is very noticeable when doing 512KB reads on a
QEMU system configured with 1500B MTU.

Also, a resent request here will prompt the responder on the
other side to immediately start resending, but the resent
packets will get stuck in the already-loaded receive queue and
will never be processed.

Rather than erroring out every time an unexpected future packet
arrives, just drop it. Eventually the retry timer will send a
duplicate request; the completer will be able to make progress since
the queue will start relatively empty.

Signed-off-by: Andrew Boyer &lt;andrew.boyer@dell.com&gt;
Signed-off-by: Doug Ledford &lt;dledford@redhat.com&gt;
diff --git a/drivers/infiniband/sw/rxe/rxe_comp.c b/drivers/infiniband/sw/rxe/rxe_comp.c
@@ -224,7 +224,7 @@ static inline enum comp_state check_psn(struct rxe_qp *qp,
 		else
 			return COMPST_DONE;
 	} else if ((diff > 0) && (wqe->mask & WR_ATOMIC_OR_READ_MASK)) {
-		return COMPST_ERROR_RETRY;
+		return COMPST_DONE;
 	} else {
 		return COMPST_CHECK_ACK;
 	}

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ static inline enum comp_state check_psn(struct rxe_qp *qp,`
`224`	`224`	`else`
`225`	`225`	`return COMPST_DONE;`
`226`	`226`	`} else if ((diff > 0) && (wqe->mask & WR_ATOMIC_OR_READ_MASK)) {`
`227`		`- return COMPST_ERROR_RETRY;`
	`227`	`+ return COMPST_DONE;`
`228`	`228`	`} else {`
`229`	`229`	`return COMPST_CHECK_ACK;`
`230`	`230`	`}`