staging: vt6655: Remove vif check from vnt_interrupt

Malcolm Priestley · gregkh · commit cc26358f89c3 · 2019-03-29T17:25:45.000+01:00
A check for vif is made in vnt_interrupt_work.

There is a small chance of leaving interrupt disabled while vif
is NULL and the work hasn't been scheduled.

Signed-off-by: Malcolm Priestley &lt;tvboxspy@gmail.com&gt;
CC: stable@vger.kernel.org # v4.2+
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
@@ -1137,8 +1137,7 @@ static irqreturn_t vnt_interrupt(int irq,  void *arg)
 {
 	struct vnt_private *priv = arg;
 
-	if (priv->vif)
-		schedule_work(&priv->interrupt_work);
+	schedule_work(&priv->interrupt_work);
 
 	MACvIntDisable(priv->PortOffset);
 

Original file line number	Diff line number	Diff line change
`@@ -1137,8 +1137,7 @@ static irqreturn_t vnt_interrupt(int irq, void *arg)`
`1137`	`1137`	`{`
`1138`	`1138`	`struct vnt_private *priv = arg;`
`1139`	`1139`
`1140`		`- if (priv->vif)`
`1141`		`- schedule_work(&priv->interrupt_work);`
	`1140`	`+ schedule_work(&priv->interrupt_work);`
`1142`	`1141`
`1143`	`1142`	`MACvIntDisable(priv->PortOffset);`
`1144`	`1143`