Bluetooth: bpa10x: make array 'req' static, shrinks object size

Colin Ian King · holtmann · commit cca32837f0f5 · 2018-01-08T21:44:22.000+01:00
Don't populate the const read-only array 'req' on the stack but instead
make it static. Makes the object code smaller by over 40 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
   8497	   3408	    128	  12033	   2f01	linux/drivers/bluetooth/bpa10x.o

After:
   text	   data	    bss	    dec	    hex	filename
   8366	   3496	    128	  11990	   2ed6	linux/drivers/bluetooth/bpa10x.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Marcel Holtmann &lt;marcel@holtmann.org&gt;
diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c
@@ -259,7 +259,7 @@ static int bpa10x_flush(struct hci_dev *hdev)
 
 static int bpa10x_setup(struct hci_dev *hdev)
 {
-	const u8 req[] = { 0x07 };
+	static const u8 req[] = { 0x07 };
 	struct sk_buff *skb;
 
 	BT_DBG("%s", hdev->name);

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,7 @@ static int bpa10x_flush(struct hci_dev *hdev)`
`259`	`259`
`260`	`260`	`static int bpa10x_setup(struct hci_dev *hdev)`
`261`	`261`	`{`
`262`		`- const u8 req[] = { 0x07 };`
	`262`	`+ static const u8 req[] = { 0x07 };`
`263`	`263`	`struct sk_buff *skb;`
`264`	`264`
`265`	`265`	`BT_DBG("%s", hdev->name);`