Skip to content

Commit cdb76be

Browse files
ming1shligit
authored andcommitted
md: raid10: retrieve page from preallocated resync page array
Now one page array is allocated for each resync bio, and we can retrieve page from this table directly. Signed-off-by: Ming Lei <tom.leiming@gmail.com> Signed-off-by: Shaohua Li <shli@fb.com>
1 parent f025061 commit cdb76be

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

drivers/md/raid10.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2055,6 +2055,7 @@ static void sync_request_write(struct mddev *mddev, struct r10bio *r10_bio)
20552055
int i, first;
20562056
struct bio *tbio, *fbio;
20572057
int vcnt;
2058+
struct page **tpages, **fpages;
20582059

20592060
atomic_set(&r10_bio->remaining, 1);
20602061

@@ -2070,6 +2071,7 @@ static void sync_request_write(struct mddev *mddev, struct r10bio *r10_bio)
20702071
fbio = r10_bio->devs[i].bio;
20712072
fbio->bi_iter.bi_size = r10_bio->sectors << 9;
20722073
fbio->bi_iter.bi_idx = 0;
2074+
fpages = get_resync_pages(fbio)->pages;
20732075

20742076
vcnt = (r10_bio->sectors + (PAGE_SIZE >> 9) - 1) >> (PAGE_SHIFT - 9);
20752077
/* now find blocks with errors */
@@ -2084,6 +2086,8 @@ static void sync_request_write(struct mddev *mddev, struct r10bio *r10_bio)
20842086
continue;
20852087
if (i == first)
20862088
continue;
2089+
2090+
tpages = get_resync_pages(tbio)->pages;
20872091
d = r10_bio->devs[i].devnum;
20882092
rdev = conf->mirrors[d].rdev;
20892093
if (!r10_bio->devs[i].bio->bi_error) {
@@ -2096,8 +2100,8 @@ static void sync_request_write(struct mddev *mddev, struct r10bio *r10_bio)
20962100
int len = PAGE_SIZE;
20972101
if (sectors < (len / 512))
20982102
len = sectors * 512;
2099-
if (memcmp(page_address(fbio->bi_io_vec[j].bv_page),
2100-
page_address(tbio->bi_io_vec[j].bv_page),
2103+
if (memcmp(page_address(fpages[j]),
2104+
page_address(tpages[j]),
21012105
len))
21022106
break;
21032107
sectors -= len/512;
@@ -2195,6 +2199,7 @@ static void fix_recovery_read_error(struct r10bio *r10_bio)
21952199
int idx = 0;
21962200
int dr = r10_bio->devs[0].devnum;
21972201
int dw = r10_bio->devs[1].devnum;
2202+
struct page **pages = get_resync_pages(bio)->pages;
21982203

21992204
while (sectors) {
22002205
int s = sectors;
@@ -2210,15 +2215,15 @@ static void fix_recovery_read_error(struct r10bio *r10_bio)
22102215
ok = sync_page_io(rdev,
22112216
addr,
22122217
s << 9,
2213-
bio->bi_io_vec[idx].bv_page,
2218+
pages[idx],
22142219
REQ_OP_READ, 0, false);
22152220
if (ok) {
22162221
rdev = conf->mirrors[dw].rdev;
22172222
addr = r10_bio->devs[1].addr + sect;
22182223
ok = sync_page_io(rdev,
22192224
addr,
22202225
s << 9,
2221-
bio->bi_io_vec[idx].bv_page,
2226+
pages[idx],
22222227
REQ_OP_WRITE, 0, false);
22232228
if (!ok) {
22242229
set_bit(WriteErrorSeen, &rdev->flags);

0 commit comments

Comments
 (0)