sched/core: Remove unnecessary down/up conversion

Nicholas Mc Guire · Ingo Molnar · commit ce2f5fe46303 · 2015-05-08T12:10:07.000+02:00
'rt_period_us' is automatically type converted from u64 to long and then cast back to u64 - this down/up conversion is unnecessary and can be removed to improve readability. This will also help us not truncate 'rt_period_us' to 32 bits on 32-bit kernels, should we ever have so large values. (unlikely, not the least due to procfs.) Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Borislav Petkov <bp@alien8.de> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1430643116-24049-1-git-send-email-hofrat@osadl.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
@@ -7738,11 +7738,11 @@ static long sched_group_rt_runtime(struct task_group *tg)
 	return rt_runtime_us;
 }
 
-static int sched_group_set_rt_period(struct task_group *tg, long rt_period_us)
+static int sched_group_set_rt_period(struct task_group *tg, u64 rt_period_us)
 {
 	u64 rt_runtime, rt_period;
 
-	rt_period = (u64)rt_period_us * NSEC_PER_USEC;
+	rt_period = rt_period_us * NSEC_PER_USEC;
 	rt_runtime = tg->rt_bandwidth.rt_runtime;
 
 	return tg_set_rt_bandwidth(tg, rt_period, rt_runtime);

Original file line number	Diff line number	Diff line change
`@@ -7738,11 +7738,11 @@ static long sched_group_rt_runtime(struct task_group *tg)`
`7738`	`7738`	`return rt_runtime_us;`
`7739`	`7739`	`}`
`7740`	`7740`
`7741`		`-static int sched_group_set_rt_period(struct task_group *tg, long rt_period_us)`
	`7741`	`+static int sched_group_set_rt_period(struct task_group *tg, u64 rt_period_us)`
`7742`	`7742`	`{`
`7743`	`7743`	`u64 rt_runtime, rt_period;`
`7744`	`7744`
`7745`		`- rt_period = (u64)rt_period_us * NSEC_PER_USEC;`
	`7745`	`+ rt_period = rt_period_us * NSEC_PER_USEC;`
`7746`	`7746`	`rt_runtime = tg->rt_bandwidth.rt_runtime;`
`7747`	`7747`
`7748`	`7748`	`return tg_set_rt_bandwidth(tg, rt_period, rt_runtime);`