Skip to content

Commit cee8f5a

Browse files
Aravind GopalakrishnanIngo Molnar
authored andcommitted
x86/mce/severity: Fix warning about indented braces
Dan reported compiler warnings about missing curly braces in mce_severity_amd(). Reindent the catch-all "return MCE_AR_SEVERITY" correctly to single tab. While at it, chain ctx == IN_KERNEL check with mcgstatus check to make it cleaner, as suggested by Boris. No functional changes are introduced by this patch. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> Signed-off-by: Borislav Petkov <bp@suse.de> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Tony Luck <tony.luck@intel.com> Cc: linux-edac <linux-edac@vger.kernel.org> Link: http://lkml.kernel.org/r/1427814281-18192-1-git-send-email-Aravind.Gopalakrishnan@amd.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent f5c8a10 commit cee8f5a

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

arch/x86/kernel/cpu/mcheck/mce-severity.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -208,12 +208,11 @@ static int mce_severity_amd(struct mce *m, int tolerant, char **msg, bool is_exc
208208
*/
209209
if (mce_flags.overflow_recov) {
210210
/* software can try to contain */
211-
if (!(m->mcgstatus & MCG_STATUS_RIPV))
212-
if (ctx == IN_KERNEL)
213-
return MCE_PANIC_SEVERITY;
211+
if (!(m->mcgstatus & MCG_STATUS_RIPV) && (ctx == IN_KERNEL))
212+
return MCE_PANIC_SEVERITY;
214213

215-
/* kill current process */
216-
return MCE_AR_SEVERITY;
214+
/* kill current process */
215+
return MCE_AR_SEVERITY;
217216
} else {
218217
/* at least one error was not logged */
219218
if (m->status & MCI_STATUS_OVER)

0 commit comments

Comments
 (0)