fs: xfs: libxfs: constify xfs_nameops structures

goyalbhumika · dchinner · commit cf7841c12d85 · 2016-11-28T14:57:42.000+11:00
Declare the structure xfs_nameops as const as it is only stored in the m_dirnameops field of a xfs_mount structure. This field is of type const struct xfs_nameops *, so xfs_nameops structures having this property can be declared as const. Done using Coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct xfs_nameops i@p = {...}; @ok1@ identifier r1.i; position p; struct xfs_mount mp; @@ mp.m_dirnameops=&i@p @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @Depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct xfs_nameops i={...}; @Depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct xfs_nameops i; File size before: text data bss dec hex filename 5302 85 0 5387 150b fs/xfs/libxfs/xfs_dir2.o File size after: text data bss dec hex filename 5318 69 0 5387 150b fs/xfs/libxfs/xfs_dir2.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
diff --git a/fs/xfs/libxfs/xfs_dir2.c b/fs/xfs/libxfs/xfs_dir2.c
@@ -93,7 +93,7 @@ xfs_ascii_ci_compname(
 	return result;
 }
 
-static struct xfs_nameops xfs_ascii_ci_nameops = {
+static const struct xfs_nameops xfs_ascii_ci_nameops = {
 	.hashname	= xfs_ascii_ci_hashname,
 	.compname	= xfs_ascii_ci_compname,
 };

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ xfs_ascii_ci_compname(`
`93`	`93`	`return result;`
`94`	`94`	`}`
`95`	`95`
`96`		`-static struct xfs_nameops xfs_ascii_ci_nameops = {`
	`96`	`+static const struct xfs_nameops xfs_ascii_ci_nameops = {`
`97`	`97`	`.hashname = xfs_ascii_ci_hashname,`
`98`	`98`	`.compname = xfs_ascii_ci_compname,`
`99`	`99`	`};`