ALSA: usb-audio: remove assignment from if condition

eldad · tiwai · commit d133f2c22e9c · 2013-08-06T10:48:22.000+02:00
Following general kernel style.

Signed-off-by: Eldad Zack &lt;eldad@fogrefinery.com&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
@@ -479,7 +479,8 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
 		subs->data_endpoint->sync_master = subs->sync_endpoint;
 	}
 
-	if ((err = snd_usb_init_pitch(subs->stream->chip, fmt->iface, alts, fmt)) < 0)
+	err = snd_usb_init_pitch(subs->stream->chip, fmt->iface, alts, fmt);
+	if (err < 0)
 		return err;
 
 	subs->cur_audiofmt = fmt;

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,8 @@ static int set_format(struct snd_usb_substream subs, struct audioformat fmt)`
`479`	`479`	`subs->data_endpoint->sync_master = subs->sync_endpoint;`
`480`	`480`	`}`
`481`	`481`
`482`		`- if ((err = snd_usb_init_pitch(subs->stream->chip, fmt->iface, alts, fmt)) < 0)`
	`482`	`+ err = snd_usb_init_pitch(subs->stream->chip, fmt->iface, alts, fmt);`
	`483`	`+ if (err < 0)`
`483`	`484`	`return err;`
`484`	`485`
`485`	`486`	`subs->cur_audiofmt = fmt;`