inode: move inode to a different list inside lock

glommer · Al Viro · commit d38fa6986e91 · 2013-09-10T18:56:30.000-04:00
When removing an element from the lru, this will be done today after the lock
is released. This is a clear mistake, although we are not sure if the bugs we
are seeing are related to this. All list manipulations are done inside the
lock, and so should this one.

Signed-off-by: Glauber Costa &lt;glommer@openvz.org&gt;
Tested-by: Michal Hocko &lt;mhocko@suse.cz&gt;
Cc: Dave Chinner &lt;dchinner@redhat.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
diff --git a/fs/inode.c b/fs/inode.c
@@ -735,9 +735,9 @@ inode_lru_isolate(struct list_head *item, spinlock_t *lru_lock, void *arg)
 
 	WARN_ON(inode->i_state & I_NEW);
 	inode->i_state |= I_FREEING;
+	list_move(&inode->i_lru, freeable);
 	spin_unlock(&inode->i_lock);
 
-	list_move(&inode->i_lru, freeable);
 	this_cpu_dec(nr_unused);
 	return LRU_REMOVED;
 }

Original file line number	Diff line number	Diff line change
`@@ -735,9 +735,9 @@ inode_lru_isolate(struct list_head item, spinlock_t lru_lock, void *arg)`
`735`	`735`
`736`	`736`	`WARN_ON(inode->i_state & I_NEW);`
`737`	`737`	`inode->i_state \|= I_FREEING;`
	`738`	`+ list_move(&inode->i_lru, freeable);`
`738`	`739`	`spin_unlock(&inode->i_lock);`
`739`	`740`
`740`		`- list_move(&inode->i_lru, freeable);`
`741`	`741`	`this_cpu_dec(nr_unused);`
`742`	`742`	`return LRU_REMOVED;`
`743`	`743`	`}`