posix-timers: Spare workqueue if there is no full dynticks CPU to kick

fweisbec · fweisbec · commit d4283c654130 · 2013-12-02T20:43:16.000+01:00
After a posix cpu timer is set, a workqueue is scheduled in order to
kick the full dynticks CPUs and let them restart their tick if
necessary in case the task they are running is concerned by the
new timer.

This kick is implemented by way of IPIs, which require interrupts
to be enabled, hence the need for a workqueue to raise them because
the posix cpu timer set path has interrupts disabled.

Now if there is no full dynticks CPU on the system, the workqueue is
still scheduled but it simply won't send any IPI and return immediately.

So lets spare that worqueue when it is not needed.

Signed-off-by: Frederic Weisbecker &lt;fweisbec@gmail.com&gt;
Cc: Thomas Gleixner &lt;tglx@linutronix.de&gt;
Cc: Ingo Molnar &lt;mingo@kernel.org&gt;
Cc: Peter Zijlstra &lt;peterz@infradead.org&gt;
Cc: Oleg Nesterov &lt;oleg@redhat.com&gt;
Cc: Steven Rostedt &lt;rostedt@goodmis.org&gt;
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
@@ -608,7 +608,8 @@ static DECLARE_WORK(nohz_kick_work, nohz_kick_work_fn);
  */
 static void posix_cpu_timer_kick_nohz(void)
 {
-	schedule_work(&nohz_kick_work);
+	if (context_tracking_is_enabled())
+		schedule_work(&nohz_kick_work);
 }
 
 bool posix_cpu_timers_can_stop_tick(struct task_struct *tsk)

Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,8 @@ static DECLARE_WORK(nohz_kick_work, nohz_kick_work_fn);`
`608`	`608`	`*/`
`609`	`609`	`static void posix_cpu_timer_kick_nohz(void)`
`610`	`610`	`{`
`611`		`- schedule_work(&nohz_kick_work);`
	`611`	`+ if (context_tracking_is_enabled())`
	`612`	`+ schedule_work(&nohz_kick_work);`
`612`	`613`	`}`
`613`	`614`
`614`	`615`	`bool posix_cpu_timers_can_stop_tick(struct task_struct *tsk)`