cpmac: remove hopeless #warning

arndb · davem330 · commit d43e6fb4ac4a · 2017-01-16T11:54:36.000-05:00
The #warning was present 10 years ago when the driver first got merged.
As the platform is rather obsolete by now, it seems very unlikely that
the warning will cause anyone to fix the code properly.

kernelci.org reports the warning for every build in the meantime, so
I think it's better to just turn it into a code comment to reduce
noise.

Signed-off-by: Arnd Bergmann &lt;arnd@arndb.de&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
@@ -1210,7 +1210,7 @@ int cpmac_init(void)
 		goto fail_alloc;
 	}
 
-#warning FIXME: unhardcode gpio&reset bits
+	/* FIXME: unhardcode gpio&reset bits */
 	ar7_gpio_disable(26);
 	ar7_gpio_disable(27);
 	ar7_device_reset(AR7_RESET_BIT_CPMAC_LO);

Original file line number	Diff line number	Diff line change
`@@ -1210,7 +1210,7 @@ int cpmac_init(void)`
`1210`	`1210`	`goto fail_alloc;`
`1211`	`1211`	`}`
`1212`	`1212`
`1213`		`-#warning FIXME: unhardcode gpio&reset bits`
	`1213`	`+ /* FIXME: unhardcode gpio&reset bits */`
`1214`	`1214`	`ar7_gpio_disable(26);`
`1215`	`1215`	`ar7_gpio_disable(27);`
`1216`	`1216`	`ar7_device_reset(AR7_RESET_BIT_CPMAC_LO);`