firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"

elfring · mfleming · commit d520dd1f348d · 2016-09-09T16:08:45.000+01:00
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring &lt;elfring@users.sourceforge.net&gt;
Cc: Greg KH &lt;gregkh@linuxfoundation.org&gt;
Cc: Julia Lawall &lt;julia.lawall@lip6.fr&gt;
Cc: Mike Waychison &lt;mikew@google.com&gt;
Cc: Michel Lespinasse &lt;walken@google.com&gt;
Signed-off-by: Matt Fleming &lt;matt@codeblueprint.co.uk&gt;
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
@@ -910,8 +910,7 @@ static __init int gsmi_init(void)
 	gsmi_buf_free(gsmi_dev.param_buf);
 	gsmi_buf_free(gsmi_dev.data_buf);
 	gsmi_buf_free(gsmi_dev.name_buf);
-	if (gsmi_dev.dma_pool)
-		dma_pool_destroy(gsmi_dev.dma_pool);
+	dma_pool_destroy(gsmi_dev.dma_pool);
 	platform_device_unregister(gsmi_dev.pdev);
 	pr_info("gsmi: failed to load: %d\n", ret);
 	return ret;
